1001402 - [tarako] Consider stripping more fireplace code from yogafire

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P1)

Description

[Mathieu Pillard [:mat]]

We might not want to do all of this because we need a plan to avoid maintaining 2 apps in the long run, but here is a small incomplete list of stuff we should consider stripping from Yogafire for performance or for package size reasons:

- All unneeded fireplace templates - this makes yogafire template.js bigger than fireplace's (since we have extra templates on top), which sucks, it should be the other way around. 

- All unneeded fireplace javascript - some views are completely unnecessary. Some modules are also irrelevant. We currently have to run code that's useless for tarako (like fireplace categories).

- All unneeded fireplace style - this is much harder to track down, but there are entire .styl files that we don't need.

- All unneeded fireplace images - most of them referenced in the style files mentioned just above. 

All these optimizations could mean better load times (much less stuff to parse and load by the javascript and css engine) and smaller memory footprint.

Comment 1

[Mathieu Pillard [:mat]]

Another (much smaller impact) one:
- All unneeded translations

Comment 2

[Mathieu Pillard [:mat]]

https://github.com/mozilla/yogafire/pull/14

Comment 3

[Wil Clouser [:clouserw]]

I'm going to block v0 on this due to L10n reasons. Let's chat in person if concerned about it.  Mathieu says it can be done tomorrow.

Comment 4

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/yogafire/commit/ddcec4865be84b17b60589932a5027d27d418fbd