1001428 - balrog submitter shouldn't forcefully capitalize product names

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

This won't work for b2g, because we need product to be "B2G".

Comment 1

[[e-mail] (:bhearsum)]

Attachment: don't call .title()

Still need to figure out how to fix all of the consumers of this. I know some of them pass lowercase "firefox", "fennec", and "thunderbird".

Comment 2

[[e-mail] (:bhearsum)]

Actually, I think this should be OK. balrog-submitter.py uses appName (which is "Firefox" and similar): https://github.com/mozilla/build-tools/blob/master/scripts/updates/balrog-submitter.py#L52. Release repacks capitalize product on their own - which is fine for now: https://github.com/mozilla/build-tools/blob/master/scripts/l10n/create-release-repacks.py#L139

Comment 3

[[e-mail] (:bhearsum)]

Thanks Rail. I think I'll wait until Monday to land this, because there's a small chance that it breaks nightlies...

Comment 4

[[e-mail] (:bhearsum)]

More fallout, this comparison stopped working: https://github.com/mozilla/build-tools/blob/master/scripts/l10n/release_repacks.sh#L40

Comment 5

[[e-mail] (:bhearsum)]

(In reply to Ben Hearsum [:bhearsum] from comment #4)
> More fallout, this comparison stopped working:
> https://github.com/mozilla/build-tools/blob/master/scripts/l10n/
> release_repacks.sh#L40

Fixed in https://hg.mozilla.org/build/tools/rev/8ce11aa0cef3