1001435 - Remove horizontal whitespace from url_bar_entry drawables

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Otherwise we have to compensate with code.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(as per bug 1000149 comment 29)

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

The files to change are .../m/a/b/resources/drawable*/url_bar_entry_*.png. Remove the padding without distorting the image content (I recommend using image magick) and then add padding to the appropriate views in XML to compensate for the padding removed from the image.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

e.g. https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/drawable-large-xhdpi-v11/url_bar_entry_default.9.png

Comment 4

[Prabhjyot Sodhi [:psd]]

Hey Anthony!
mfinkle suggested that you could help with the new images
Thanks :)

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Hey, Prabhjyot. I just wanted to let you know that removing the whitespace from these assets is turning out to be more complicated than I initially thought - I'm not sure the specifics of how whitespace works with regards to nine patches (if you're curious [1]) - we'll get back to you ASAP!

[1]: https://developer.android.com/guide/topics/graphics/2d-graphics.html#nine-patch

Comment 6

[Prabhjyot Sodhi [:psd]]

Hey Michael!
No problem. I would be happy to help whenever the need be :)

Comment 7

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: 9 patch experiment.zip

Hey guys, I've removed the empty space on all sides. These are the assets for the phone UI. Maybe we can give this a try and see how it goes before I prep the Tablet UI stuff. 

Let me know how it goes!

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Hey, Prabhjyot - we're still trying to figure out some details on how we're going to use these assets so I'll give you the word when we're ready to go.

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Updated 9 patches (phone)

Okay, Prabhjyot - sorry for the wait! I ran a utility called trimage over the images to reduce their sizes and have uploaded the result - let me know if there's anything wrong with the archive you receive.

Your mission is to replace the associated resources we currently have in mobile/android/base/resources/ with these assets, and then ensure that the toolbar is 32 dp tall, 245 dp wide when collapsed, and 304 dp wide when expanded.

We'll work on tablet once we get the phone working properly.

Ready? Go!

Comment 10

[Prabhjyot Sodhi [:psd]]

Hey!
For this patch,
say for the first file 'urlbar_active_hdpi.9.png' in the attachment given by you
I'll open mobile/android/base/drawable-hdpi/ where I find 
url_bar_entry_pressed.9.png
and hg remove it and replace it by the first file in the attachment ( and also rename this file before doing hg add to it)
and repeat for all files.
Is this supposed to be done?

Comment 11

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Right!

I recommend using a script to simplify this process. If you're using zsh (on different files), for example:

  for i in {m,h,xh,xxh}; do pushd drawable-${i}dpi/ && mv ~/dl/sb/b3/icon_bookmark_${i}dpi.png new_tablet_ic_menu_bookmark_add.png; popd; done

Comment 12

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Updated 9 patches (tablet)

Comment 13

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://mail.mozilla.org/pipermail/mobile-firefox-dev/2015-February/001090.html

Comment 14

[Prabhjyot Sodhi [:psd]]

Hey Michael!
I am kinda busy with with my college proceedings!
I will get back to this asap :)

Comment 15

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Okay, thanks for getting back to me.

Comment 16

[Prabhjyot Sodhi [:psd]]

Hey Hey!
will have to do this manually, I think

Comment 17

[Prabhjyot Sodhi [:psd]]

Hey mcomella,
I think I will have to do this manually, or maybe write a script that changes the filenames to the ones already present, and then use the script that you were suggesting[1]
Any thoughts?

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1001435#c11

Comment 18

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Prabhjyot Sodhi [:psd] from comment #17)
> I think I will have to do this manually,

While it'd work, this is a bit tedious and time-consuming.

> or maybe write a script that changes the filenames to the ones already present,
> and then use the script that you were suggesting[1]
> Any thoughts?

My script changes the filenames to the ones present, provided you swap out the arguments correctly. Do you understand what it is doing?

By the way, you can add me to the "Need more information from" box below the comment box so I get a notification and am more likely to see your questions.

Comment 19

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Still interested in this one, Prabhjyot? If not, no worries - I just want to open this up for someone else if possible.

Comment 20

[Prabhjyot Sodhi [:psd]]

Sorry for blocking this all this while. I'll unblock it for now and probably take a stab at it after I am done with that other bug :)

Comment 21

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

This will be fixed in due time if it's important.