1001454 - [b2gperf] Unable to flick through homescreen pages

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect, P1)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

b2gperf has been unable to flick through the homescreen pages to gather FPS results since April 11th. I was able to narrow the regression range down to:

Gecko good: d41e6e32df81
Gecko bad: 783c5013dbec
Gecko pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d41e6e32df81&tochange=783c5013dbec

There were no changes in Gaia between these two tinderbox builds.

I strongly suspect bug 958036 has caused this to regress.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

:mdas this still appears to be an issue. I can replicate using the following:

$ b2gperf --test-type=scrollfps --reset Homescreen

Are you able to replicate this?

Comment 2

[Malini Das [:mdas] - Away, not checking bugmail]

It's definitely related to the apz code. In the logcat, we have:

E/GeckoConsole(  618): [JavaScript Error: "iframe is undefined" {file: "chrome://marionette/content/marionette-listener.js" line: 120}]

when attempting to emit the touch events, which is from the new code. I'll investigate this now.

Comment 3

[Malini Das [:mdas] - Away, not checking bugmail]

Attachment: fix frameId assignment

When passing frameId (which is the index into window.frames) of 0, this line would assign it to null and would cause problems later on when we tried to use that frameId to inject touch events into it via the root process.

Comment 4

[Malini Das [:mdas] - Away, not checking bugmail]

Btw, I'm not sure why we did that conditional assignment, it doesn't seem to really do anything. I'm running through try to verify

try for emulator Mn, webapi:
https://tbpl.mozilla.org/?tree=Try&rev=8e0c8a7929be

try for Gu:
https://tbpl.mozilla.org/?tree=Try&rev=826b615c22e2

Comment 5

[Malini Das [:mdas] - Away, not checking bugmail]

tries are green

Comment 6

[Malini Das [:mdas] - Away, not checking bugmail]

landed on m-i
https://hg.mozilla.org/integration/mozilla-inbound/rev/d74281e6d571

Comment 7

[Malini Das [:mdas] - Away, not checking bugmail]

landed as:

https://hg.mozilla.org/mozilla-central/rev/d74281e6d571

I landed it with the wrong bug number in the commit :(