Closed Bug 1001458 Opened 6 years ago Closed 6 years ago

Rename TileIterator into BigImageIterator

Categories

(Core :: Graphics: Layers, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: nical, Assigned: nical)

Details

Attachments

(1 file)

We have two things in our layers code that use the term "tile":
* tiled layers (that managed several Texture(Client/Host) objects
* texture objects that are broken down into smaller textures internally to not hit the GPU's max texture size.

This keeps confusing people so let's just rename the second one "BigImage" (we already call it BigImage in some places).
Attached patch RenamedSplinter Review
sed -i 's/TileIterator/BigImageIterator/g' **/*.h **/*.cpp
sed -i 's/TileIteration/BigImageIteration/g' **/*.h **/*.cpp
sed -i 's/tileIter/bigImgIter/g' **/*.h **/*.cpp
Assignee: nobody → nical.bugzilla
Attachment #8412666 - Flags: review?(bgirard)
Comment on attachment 8412666 [details] [diff] [review]
Renamed

Review of attachment 8412666 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the regex with the review.

BigImage is a more common term for this anyways so this is much better.
Attachment #8412666 - Flags: review?(bgirard) → review+
https://hg.mozilla.org/mozilla-central/rev/408998b14b5d
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.