1001503 - [Camera] unlock camera from lockscreen goes to image preview, not active viewfinder

Status: RESOLVED DUPLICATE of bug 988670

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Tony Chung [:tchung]]

If the camera preview process is running in the preview mode, unlocking the camera from lockscreen will directly load the preview mode; not the camera viewfinder.   With 1.3, unlocking camera from lockscreen will always go to camera viewfinder

Repro:
1) install 1.4 nightly on Flame or Buri
Gaia      58578bcb4886c66fb30038c071e460fd57e49102
Gecko     https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/a86cef581475
BuildID   20140424000201
Version   30.0a2
ro.build.version.incremental=76
2) open camera, take a picture, click preview to view your image
3) quickly power the device off and back on 
4) on lockscreen, slide to the left to launch camera
5) Verify you're still on the preview screen, not a active camera viewfinder

Expected:
Users will want to quickly unlock their device to see the camera and take a picture, not view an old image from the last picture they took

Actual:
- unlocking camera shows camera preview mode

Comment 1

[Pi Wei Cheng [:piwei] (inactive)]

This issue does NOT reproduce on today's 2.0 master build. It appears that something fixed it on master very recently.
The following regression window is for when it initially broke on master.

b2g-inbound Regression Window:

Last Working Environmental Variables:
Device: Buri MOZ
BuildID: 20140415002702
Gaia: 5576f4568618f4a57b887910fb2c6f00ea9d0d08
Gecko: acfc8089f7a2
Version: 31.0a1
Firmware Version: v1.2-device.cfg

First Broken Environmental Variables:
Device: Buri MOZ
BuildID: 20140415004202
Gaia: 7afce8a6e965a45f38988227828ccdfb315394f3
Gecko: 4f9f1be9e587
Version: 31.0a1
Firmware Version: v1.2-device.cfg

Last Working Gaia / First Broken Gecko: Issue Does NOT reproduce
Gaia: 5576f4568618f4a57b887910fb2c6f00ea9d0d08
Gecko: 4f9f1be9e587

Last Working Gecko / First Broken Gaia: Issue DOES reproduce
Gaia: 7afce8a6e965a45f38988227828ccdfb315394f3
Gecko: acfc8089f7a2

Gaia Pushlog:
https://github.com/mozilla-b2g/gaia/compare/5576f4568618f4a57b887910fb2c6f00ea9d0d08...7afce8a6e965a45f38988227828ccdfb315394f3

Comment 2

[Jason Smith [:jsmith]]

Can we get this window against 1.4?

Comment 3

[Wilson Page [:wilsonpage]]

We now always close the preview-gallery when the camera app is hidden. This means it is not possible to revisit the camera app and see the preview-gallery. I'm guessing this has not been uplifted to 1.4.

Comment 4

[Pi Wei Cheng [:piwei] (inactive)]

While I was doing the regression window on 1.4, I found that this reproduces all the way back to 3/26 where the old camera UI was present. Comment 3 proves my suspicion that this was never working on 1.4.

Removing regression window wanted tag for now. Please let me know if any more information is needed.

Comment 5

[Tony Chung [:tchung]]

FWIW, if the lockscreen passcode is enabled, this issue does NOT reproduce.  at the passcode screen, if the user opts to bypass the code and tap the camera App icon, then it will take them to the active viewfinder mode.  

This only happens when there is no passcode enabled, and you swipe left to launch camera from lockscreen.

Comment 6

[Tony Chung [:tchung]]

(In reply to Wilson Page [:wilsonpage] from comment #3)
> We now always close the preview-gallery when the camera app is hidden. This
> means it is not possible to revisit the camera app and see the
> preview-gallery. I'm guessing this has not been uplifted to 1.4.

Wilson, is there a bug tracking that work that was done on master?  if so, can you mark this bug dependent of that uplift?  (once this gets triaged for 1.4+, of course)

Comment 7

[David Flanagan [:djf]]

Note that in Tony's description he has "slide to the left" which means he is not using the camera from a locked (with a PIN) lockscreen. So we're not in secure mode, just reopening the camera.

If we want this fixed in 1.4, it should be a simple matter of uplifting the relevant patch from master.

While we're at it, we should check to ensure that we are doing the right thing if hte lockscreen has a pin.

Comment 8

[Justin D'Arcangelo [:justindarc]]

I believe this should have been addressed by Bug 987071 -- looks like it was uplifted to 1.4 though according to the bug comments

Comment 9

[Justin D'Arcangelo [:justindarc]]

Patch for Bug 988670 fixes this. It has landed on master (which is why it is not reproducible there), but hasn't been uplifted to 1.4. I'm going to create a 1.4 patch for Bug 988670. Closing this as a dupe.