Closed
Bug 1001521
Opened 10 years ago
Closed 10 years ago
Fix tabview tests that remove the original tab
Categories
(Firefox Graveyard :: Panorama, defect)
Firefox Graveyard
Panorama
Tracking
(firefox30 fixed, firefox31 fixed, firefox32 fixed, b2g-v1.4 fixed, b2g-v2.0 fixed)
RESOLVED
FIXED
Firefox 32
People
(Reporter: ttaubert, Assigned: ttaubert)
Details
Attachments
(1 file)
26.62 KB,
patch
|
smacleod
:
review+
|
Details | Diff | Splinter Review |
Bug 805068 wants to make tests fail that remove the original tab: TEST-UNEXPECTED-FAIL | browser/components/tabview/test/browser_tabview_bug595601.js | Test destroyed original tab TEST-UNEXPECTED-FAIL | browser/components/tabview/test/browser_tabview_bug600812.js | Test destroyed original tab TEST-UNEXPECTED-FAIL | browser/components/tabview/test/browser_tabview_bug608153.js | Test destroyed original tab TEST-UNEXPECTED-FAIL | browser/components/tabview/test/browser_tabview_bug608158.js | Test destroyed original tab TEST-UNEXPECTED-FAIL | browser/components/tabview/test/browser_tabview_bug608405.js | Test destroyed original tab TEST-UNEXPECTED-FAIL | browser/components/tabview/test/browser_tabview_bug624847.js | Test destroyed original tab TEST-UNEXPECTED-FAIL | browser/components/tabview/test/browser_tabview_bug626455.js | Test destroyed original tab TEST-UNEXPECTED-FAIL | browser/components/tabview/test/browser_tabview_bug633788.js | Test destroyed original tab TEST-UNEXPECTED-FAIL | browser/components/tabview/test/browser_tabview_bug685692.js | Test destroyed original tab
Assignee | ||
Comment 1•10 years ago
|
||
We have a few tests that remove the last tab group so the best solution is to just run all of those in a new window. I didn't want to spend much time on making the tests nicer so I just modified lines where needed. Steven, forgive me for asking you to review Panorama patches but I hope those test fixes shouldn't be too hard :) There are virtually no Panorama reviewers left...
Comment 2•10 years ago
|
||
Comment on attachment 8412744 [details] [diff] [review] 0002-Bug-1001521-Fix-tabview-tests-that-remove-the-origin.patch Review of attachment 8412744 [details] [diff] [review]: ----------------------------------------------------------------- > Steven, forgive me for asking you to review Panorama patches but I hope > those test fixes shouldn't be too hard :) There are virtually no Panorama > reviewers left... No worries, wasn't bad. LGTM.
Attachment #8412744 -
Flags: review?(smacleod) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/19681dccb432
Whiteboard: [fixed-in-fx-team]
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/19681dccb432
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 32
Comment 5•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/e12ea8ad12e8 https://hg.mozilla.org/releases/mozilla-beta/rev/d20b23d033e4
Comment 6•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/d20b23d033e4
status-b2g-v1.4:
--- → fixed
status-b2g-v2.0:
--- → fixed
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•