Fix tabview tests that remove the original tab

RESOLVED FIXED in Firefox 30

Status

defect
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

Trunk
Firefox 32
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox30 fixed, firefox31 fixed, firefox32 fixed, b2g-v1.4 fixed, b2g-v2.0 fixed)

Details

Attachments

(1 attachment)

Bug 805068 wants to make tests fail that remove the original tab:

TEST-UNEXPECTED-FAIL | browser/components/tabview/test/browser_tabview_bug595601.js | Test destroyed original tab
TEST-UNEXPECTED-FAIL | browser/components/tabview/test/browser_tabview_bug600812.js | Test destroyed original tab
TEST-UNEXPECTED-FAIL | browser/components/tabview/test/browser_tabview_bug608153.js | Test destroyed original tab
TEST-UNEXPECTED-FAIL | browser/components/tabview/test/browser_tabview_bug608158.js | Test destroyed original tab
TEST-UNEXPECTED-FAIL | browser/components/tabview/test/browser_tabview_bug608405.js | Test destroyed original tab
TEST-UNEXPECTED-FAIL | browser/components/tabview/test/browser_tabview_bug624847.js | Test destroyed original tab
TEST-UNEXPECTED-FAIL | browser/components/tabview/test/browser_tabview_bug626455.js | Test destroyed original tab
TEST-UNEXPECTED-FAIL | browser/components/tabview/test/browser_tabview_bug633788.js | Test destroyed original tab
TEST-UNEXPECTED-FAIL | browser/components/tabview/test/browser_tabview_bug685692.js | Test destroyed original tab
We have a few tests that remove the last tab group so the best solution is to just run all of those in a new window. I didn't want to spend much time on making the tests nicer so I just modified lines where needed.

Steven, forgive me for asking you to review Panorama patches but I hope those test fixes shouldn't be too hard :) There are virtually no Panorama reviewers left...
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Attachment #8412744 - Flags: review?(smacleod)
Comment on attachment 8412744 [details] [diff] [review]
0002-Bug-1001521-Fix-tabview-tests-that-remove-the-origin.patch

Review of attachment 8412744 [details] [diff] [review]:
-----------------------------------------------------------------

> Steven, forgive me for asking you to review Panorama patches but I hope
> those test fixes shouldn't be too hard :) There are virtually no Panorama
> reviewers left...

No worries, wasn't bad. LGTM.
Attachment #8412744 - Flags: review?(smacleod) → review+
https://hg.mozilla.org/mozilla-central/rev/19681dccb432
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 32
No longer blocks: 805068
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.