1001530 - [Camera][Perf] Don't block startup waiting for activities

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Comment 1

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

Comment 2

[Justin D'Arcangelo [:justindarc]]

Wilson: The 1.3T patch in Bug 989290 needs to be incorporated in with our `pick` activity handling.

Comment 3

[Justin D'Arcangelo [:justindarc]]

Wilson: Patch seems to run ok for me and I'm not seeing any issues with Activities. Before I R+ though, it looks like we have 2 test failures:

- [camera-test/unit/lib/camera_test.js] Should emit a 'busy' event
Error: expected false to be truthy
    at chaiAssert (http://camera.gaiamobile.org:8080/common/test/helper.js:33:1)
    at get (http://camera.gaiamobile.org:8080/common/vendor/chai/chai.js:352:1)
    at ok (http://camera.gaiamobile.org:8080/common/vendor/chai/chai.js:1225:5)
    at (anonymous) (http://camera.gaiamobile.org:8080/test/unit/lib/camera_test.js:169:7)
    at wrapper (http://camera.gaiamobile.org:8080/common/test/mocha_generators.js:62:13)
    at run (http://camera.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709:7)
    at runTest (http://camera.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4081:5)
    at (anonymous) (http://camera.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4127:7)
    at next (http://camera.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4007:7)
    at (anonymous) (http://camera.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4016:7)
    at next (http://camera.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3964:16)
    at (anonymous) (http://camera.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3979:7)
    at done (http://camera.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3700:5)
    at (anonymous) (http://camera.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3712:9)
    at (anonymous) (http://camera.gaiamobile.org:8080/common/test/mocha_generators.js:46:13)
    at wrapper (http://camera.gaiamobile.org:8080/common/test/mocha_generators.js:73:15)
    at run (http://camera.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709:7)
    at next (http://camera.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3973:5)
    at (anonymous) (http://camera.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984:5)
    at (anonymous) (http://camera.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932:28)

- [camera-test/unit/lib/camera_test.js] Should set the following onSuccess
Error: expected false to be truthy
    at chaiAssert (http://camera.gaiamobile.org:8080/common/test/helper.js:33:1)
    at get (http://camera.gaiamobile.org:8080/common/vendor/chai/chai.js:352:1)
    at ok (http://camera.gaiamobile.org:8080/common/vendor/chai/chai.js:1225:5)
    at (anonymous) (http://camera.gaiamobile.org:8080/test/unit/lib/camera_test.js:256:7)
    at wrapper (http://camera.gaiamobile.org:8080/common/test/mocha_generators.js:62:13)
    at run (http://camera.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709:7)
    at runTest (http://camera.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4081:5)
    at (anonymous) (http://camera.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4127:7)
    at next (http://camera.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4007:7)
    at (anonymous) (http://camera.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4016:7)
    at next (http://camera.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3964:16)
    at (anonymous) (http://camera.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3979:7)
    at done (http://camera.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3700:5)
    at (anonymous) (http://camera.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3712:9)
    at (anonymous) (http://camera.gaiamobile.org:8080/common/test/mocha_generators.js:46:13)
    at wrapper (http://camera.gaiamobile.org:8080/common/test/mocha_generators.js:73:15)
    at run (http://camera.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709:7)
    at next (http://camera.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3973:5)
    at (anonymous) (http://camera.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984:5)
    at (anonymous) (http://camera.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932:28)

In addition to those, we should either integrate the patch for Bug 989290 into this one, unless you think we should instead do a follow-up patch for that? Your call.

Comment 4

[Wilson Page [:wilsonpage]]

justindarc: Travis Green and ready to land.

Comment 5

[Wilson Page [:wilsonpage]]

Landed on 'master': https://github.com/wilsonpage/gaia/commit/ba30d55b342ba0b28eb18647c1440884296d1d7b

Comment 6

[Russ Nicoletti [:russn]]

NI for Wilson

Hi Wilson, I noticed while merging changes for bug 1001724 into master that as part of this bug you commented-out the 'displayImage embedded preview, bigEnough=true' test in camera/test/unit/media_frame_test.js. After merging bug 1001724 changes, I uncommented out this test and it passed. Is there a reason is should be commented out? Thanks in advance for the info.

Comment 7

[Wilson Page [:wilsonpage]]

russn: Apologies, I don't that should have been committed. I was having issues running that particular test locally.

I also have issues with the fact that this is a 'shared' library, but its unit-tests reside in the camera app. Is there a better place we can move this?

Comment 8

[Russ Nicoletti [:russn]]

There is a bug to move unit tests for shared code out of gallery (bug 841422). It would seem straightforward to take the same approach for the unit tests for shared code in camera -- to move them to the 'sharedtest' app.

Btw, whoever moves the media_frame_test into 'sharedtest' can uncomment out the test mentioned in comment #6.