Investigate UI issues/changes for the find bar on OS X.

RESOLVED FIXED in Thunderbird 41.0

Status

enhancement
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: jsbruner, Assigned: jsbruner)

Tracking

Trunk
Thunderbird 41.0
All
macOS

Thunderbird Tracking Flags

(thunderbird38+ fixed, thunderbird39 fixed, thunderbird40 fixed, thunderbird41 fixed)

Details

Attachments

(3 attachments, 2 obsolete attachments)

We could probably make some changes to the find bar on OS X (Some buttons need a hover state, margins, etc). This bug will attempt to fix those.
Posted patch Find/Replace hover and active styling. (obsolete) β€” β€” Splinter Review
I'm frankly not sure why I filed this bug in such a broad sense, because this was really the only thing I noticed needed to be added.
Attachment #8594519 - Flags: review?(richard.marti)
This button looks totally different to the other two buttons. Wouldn't it be better to give this button the class="findbar-button" like the others two have? Then applying the rules to .findbar-button would make them look all the same.

FX has added rules to browser.css to make them look like normal toolbar-buttons. We could also follow this way? This would also need changes on Windows, which I could do.
Posted patch FindbarButtons.patch (obsolete) β€” β€” Splinter Review
Sorry to add a patch in your bug.

I added the findbar-button class to replaceButton and applied the toolbarbutton-1 rules to the findbar-buttons like FX has done. What do you think about this?

I also fixed the inactive forward button dropmarker-button fix from bug 1150627 moved to this bug and made some cleanup (moved the :hover or :active to the end of the selectors for easier reading and also fixed the hover on checked button rule).

I'd like if this patch could go to TB 38 to fix the replaceButton feedback.
Attachment #8594705 - Flags: review?(josiah)
We seem to have dueling patches here, and you are stalled on something that you want in TB 38. Any chance we could get this resolved? So close ...
Flags: needinfo?(richard.marti)
Flags: needinfo?(josiah)
Josiah preferred over IRC my patch. I r- his patch to make it easier to follow.
Flags: needinfo?(richard.marti)
Comment on attachment 8594519 [details] [diff] [review]
Find/Replace hover and active styling.

As written in comment 7 I set r- as the other patch is preferred.
Attachment #8594519 - Flags: review?(richard.marti) → review-
(In reply to Richard Marti (:Paenglab) from comment #7)
> Josiah preferred over IRC my patch. I r- his patch to make it easier to
> follow.

Indeed. I'll review Richard's over the weekend.
Flags: needinfo?(josiah)
Posted patch FindbarButtons.patch β€” β€” Splinter Review
Now with padding.
Attachment #8594519 - Attachment is obsolete: true
Attachment #8594705 - Attachment is obsolete: true
Attachment #8594705 - Flags: review?(josiah)
Attachment #8603573 - Flags: review?(josiah)
Attachment #8603573 - Flags: review?(josiah) → review+
Comment on attachment 8603573 [details] [diff] [review]
FindbarButtons.patch

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: On OS X the Replace button isn't visible as a button.
Testing completed (on c-c, etc.): Awaiting c-c landing.
Risk to taking this patch (and alternatives if risky): Low, mostly CSS.

No approval‑comm‑esr38 flag to set.
Attachment #8603573 - Flags: approval-comm-beta?
Attachment #8603573 - Flags: approval-comm-aurora?
https://hg.mozilla.org/comm-central/rev/b1239e93c6a5 -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 41.0
You need to log in before you can comment on or make changes to this bug.