Closed
Bug 1001562
Opened 10 years ago
Closed 10 years ago
Make SetXBLInsertionParent(nullptr) and SetXBLBinding(nullptr, ...) lazier
Categories
(Core :: XBL, defect)
Core
XBL
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: mccr8, Assigned: mccr8)
References
Details
Attachments
(2 files)
2.90 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
2.75 KB,
patch
|
mccr8
:
checkin-
|
Details | Diff | Splinter Review |
FragmentOrElement::SetXBLInsertionParent(nullptr) ends up slots if none exists, which is unnecessary. This is a problem if you call it after LastRelease(), which I'd like to do in bug 996151, but I think it is a reasonable improvement in any case.
Assignee | ||
Comment 1•10 years ago
|
||
> ends up slots if none exists
This should be "ends up creating slots if none exists".
Assignee | ||
Comment 2•10 years ago
|
||
It looks like a similar change can be made for FragmentOrElement::SetXBLBinding().
Assignee | ||
Updated•10 years ago
|
Summary: Make FragmentOrElement::SetXBLInsertionParent(nullptr) lazier → Make SetXBLInsertionParent(nullptr) and SetXBLBinding(nullptr, ...) lazier
Assignee | ||
Comment 3•10 years ago
|
||
try run with asserts: https://tbpl.mozilla.org/?tree=Try&rev=9f4d86c48972 try run without asserts: https://tbpl.mozilla.org/?tree=Try&rev=00aafe8bcef0
Attachment #8413456 -
Flags: review?(bugs)
Assignee | ||
Comment 4•10 years ago
|
||
Olli suggested this approach to figuring out why nodes weren't clearing their slots. I'm just attaching this for posterity.
Comment 5•10 years ago
|
||
Comment on attachment 8413456 [details] [diff] [review] Make SetXBLInsertionParent(nullptr) and SetXBLBinding(nullptr, ...) lazier. Do we want this on branches too? Looks rather bad to me.
Attachment #8413456 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c25984096097 > Looks rather bad to me. Why is that? Do you think this will greatly increase the number of nodes with slots?
Assignee | ||
Updated•10 years ago
|
Attachment #8413457 -
Flags: checkin-
Comment 7•10 years ago
|
||
That and re-creating slots is odd too - but I guess the latter doesn't lead to any real problems after all.
https://hg.mozilla.org/mozilla-central/rev/c25984096097
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Assignee | ||
Comment 9•10 years ago
|
||
(In reply to Andrew McCreight [:mccr8] from comment #6) > Why is that? Do you think this will greatly increase the number of nodes > with slots? If you think this should go on branches, feel free to fill out the approval request. I think you understand the issue and potential problems better than me.
You need to log in
before you can comment on or make changes to this bug.
Description
•