1001618 - [B2G][Contacts][Import]Plugging in USB cable while importing contacts from SD card does not halt import.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Ross Kuhlman ([e-mail])]

If USB sharing is enabled and the device is importing contacts from the SD card, the import process will not stop when the user plugs a USB cable into the device. While contacts are being downloaded, the user can add and remove files to the SD card via USB cable.

Repro Steps:
1) Updated Buri to BuildID: 20140423000203
2) Launch Settings app and enable USB sharing.
3) Launch Contacts app.
4) Tap Gear Icon > Import Contacts.
5) Import Contacts from SD Card.
6) When the screen displays "X/Y contacts downloaded", plug in USB cable. *This step is mandatory. If USB cable is plugged in before contacts count is displayed, the issue will not occur.

Actual:
Contacts continue to import and user can simultaneously add/remove files from the SD card via USB.

Expected:
Contacts will stop importing, and user is informed that USB cable must be removed to continue.
-OR-
USB connection is not established until import process is complete.

Environmental Variables:
Device: Buri v1.4 Moz RIL
BuildID: 20140423000203
Gaia: 25d53d442cbf17c150575c98979e957ae040e023
Gecko: 2d1b4d36eef9
Version: 30.0a2
Firmware Version: v1.2-device.cfg

Notes:
unable to provide logcat because device must not be plugged in during first steps

Repro frequency: 100%

Comment 1

[Jason Smith [:jsmith]]

Does this happen on 1.3?

Comment 2

[Duane Dixon [:ddixon]]

Issue DOES reproduce on latest Buri 1.3 build. 

While contacts were importing from SD Card, user was able to connect USB cable to computer and import photos simultaneously. 

1.3 Environmental Variables:
Device: buri 1.3 MOZ
BuildID: 20140425024003
Gaia: 32a9e3db738e0b3bc44a4d4d5c16512a2617a2cf
Gecko: c96b0cf6343f
Version: 28.0
Firmware Version: v1.2-device.cfg

Comment 3

[Dave Hylands [:dhylands]]

Hmm. The AutoMounter detects open files on the sdcard and prevents sharing of the sdcard with the PC as long as there are open files.

What APIs are being used to read the contacts from the sdcard?

Comment 4

[Dave Hylands [:dhylands]]

(In reply to rkuhlman from comment #0)
> Notes:
> unable to provide logcat because device must not be plugged in during first
> steps

Grab the logcat after plugging in the cable. logcat is a circular buffer on the phone, so you'll still get messages in logcat from before when the cable was plugged in.

Comment 5

[Duane Dixon [:ddixon]]

Attachment: Logcat_1001618

Comment 6

[Dave Hylands [:dhylands]]

I see no evidence of open files in the logcat (the AutoMounter reports each open file and defers sharing until the files are all closed).

So the only conclusion I can come to is that importing contacts may have read all it needed from the sdcard and is doing additional processing while sdcard is being shared.

Without knowing the exact flow of how contacts are imported, its just speculation right now.

Comment 7

[Anindya-Pandey]

Hi,
I'm new to open source.
I'm looking for my first bug.
I'll be needing help.
Can you assign this bug to me?

Comment 8

[Anindya-Pandey]

Hi,
I'm new to open source.
I'm looking for my first bug.
I'll be needing help.
Can you assign this bug to me?

Comment 9

[Dave Hylands [:dhylands]]

I can assign the bug to you.

Comment 10

[Anindya-Pandey]

(In reply to Dave Hylands [:dhylands] from comment #9)
> I can assign the bug to you.

I am using Gaia in Firefox Mulet. How do I plug in a USB cable or insert an SD card?

Comment 11

[Dave Hylands [:dhylands]]

You don't. This requires using a real device.

Comment 12

[Anindya-Pandey]

(In reply to Dave Hylands [:dhylands] from comment #11)
> You don't. This requires using a real device.

Really sorry for the late reply.

I've been going through sdcard.js, usb_storage.js and the import js files in shared/js/contacts/import/ .

The USB connection will not be established as long as automounter is disabled.Am I right?

Comment 13

[Francisco Jordano [:arcturus] [:francisco]]

Yes, you are right. As Dave commented, you'll need the real device to test this.

Comment 14

[Anindya-Pandey]

Im sorry I don't have a real device

Comment 15

[BMO Automation]

Firefox OS is not being worked on