1001666 - Move non-essential stuff outside of include.js

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Code Quality, defect, P3)

Description

[Wil Clouser [:clouserw]]

From bug 987895:

> > 7] include.js is clearly a bottleneck for you. It seems to load most of the
> > other resources (sometimes indirectly?), but that can't happen until the
> > script is loaded completely... and it appears to have a lot of stuff that is
> > extraneous to the frontpage on it.. credits.html for example is inlined in
> > it. it seems you would be much better off loading that stuff separately.

Comment 1

[Mathieu Pillard [:mat]]

Currently include.js contains everything: the javascript for the views, helpers, all the js code, but also all the templates, inlined.

Splitting it into two files would allows us to get the XHRs sooner, but it's non-trivial, because what's essential varies from page to page. Since we are a single page app, https://marketplace.firefox.com/credits loads the same HTML+JS+CSS as https://marketplace.firefox.com/, we choose the template to display in JavaScript. IMHO changing that is non-trivial and risky, and we might get more headaches than performance gains.