Closed
Bug 1001682
Opened 10 years ago
Closed 10 years ago
Don't reverse the R and B components in the GL CopyDataSourceSurface code for SurfaceFormat::R5G6B5
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla32
Tracking | Status | |
---|---|---|
fennec | 31+ | --- |
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
Attachments
(1 file, 1 obsolete file)
1.09 KB,
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
We shouldn't be reversing the R and B components in the GL CopyDataSourceSurface code for SurfaceFormat::B8G8R8X8.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8412982 -
Flags: review?(matt.woodrow)
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8412982 -
Attachment is obsolete: true
Attachment #8412982 -
Flags: review?(matt.woodrow)
Attachment #8412983 -
Flags: review?(matt.woodrow)
Comment 3•10 years ago
|
||
Comment on attachment 8412983 [details] [diff] [review] patch Review of attachment 8412983 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/gl/GLReadTexImageHelper.cpp @@ +261,5 @@ > size_t destRowHole = aDest->Stride() - destRowBytes; > > bool needsRBSwap = false; > if (aDest->GetFormat() == SurfaceFormat::B8G8R8A8 || > + aDest->GetFormat() == SurfaceFormat::B8G8R8X8) { I'm confused about this. The bug talks about B8G8R8X8, but the patch only appears to change R5G6B5.
Assignee | ||
Comment 4•10 years ago
|
||
Sorry, I meant R5G6B5. It's the erroneous handling of R5G6B5 that is causing android tests to fail with the patch for bug 1001683.
Summary: Don't reverse the R and B components in the GL CopyDataSourceSurface code for SurfaceFormat::B8G8R8X8 → Don't reverse the R and B components in the GL CopyDataSourceSurface code for SurfaceFormat::R5G6B5
Updated•10 years ago
|
Attachment #8412983 -
Flags: review?(matt.woodrow) → review+
Assignee | ||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2c14ea7a713c
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2c14ea7a713c
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Comment 9•10 years ago
|
||
Can we uplift this to Fx31? It fixes a test failure we need to EOL Android 2.2
tracking-fennec: --- → 31+
You need to log in
before you can comment on or make changes to this bug.
Description
•