Closed Bug 1001682 Opened 10 years ago Closed 10 years ago

Don't reverse the R and B components in the GL CopyDataSourceSurface code for SurfaceFormat::R5G6B5

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla32
Tracking Status
fennec 31+ ---

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(1 file, 1 obsolete file)

We shouldn't be reversing the R and B components in the GL CopyDataSourceSurface code for SurfaceFormat::B8G8R8X8.
Attached patch patch (obsolete) — Splinter Review
Attachment #8412982 - Flags: review?(matt.woodrow)
Attached patch patchSplinter Review
Attachment #8412982 - Attachment is obsolete: true
Attachment #8412982 - Flags: review?(matt.woodrow)
Attachment #8412983 - Flags: review?(matt.woodrow)
Blocks: 1001683
Comment on attachment 8412983 [details] [diff] [review]
patch

Review of attachment 8412983 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLReadTexImageHelper.cpp
@@ +261,5 @@
>    size_t destRowHole = aDest->Stride() - destRowBytes;
>  
>    bool needsRBSwap = false;
>    if (aDest->GetFormat() == SurfaceFormat::B8G8R8A8 ||
> +      aDest->GetFormat() == SurfaceFormat::B8G8R8X8) {

I'm confused about this. The bug talks about B8G8R8X8, but the patch only appears to change R5G6B5.
Sorry, I meant R5G6B5. It's the erroneous handling of R5G6B5 that is causing android tests to fail with the patch for bug 1001683.
Summary: Don't reverse the R and B components in the GL CopyDataSourceSurface code for SurfaceFormat::B8G8R8X8 → Don't reverse the R and B components in the GL CopyDataSourceSurface code for SurfaceFormat::R5G6B5
Attachment #8412983 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/2c14ea7a713c
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Can we uplift this to Fx31? It fixes a test failure we need to EOL Android 2.2
tracking-fennec: --- → 31+
You need to log in before you can comment on or make changes to this bug.