Closed Bug 1001687 Opened 6 years ago Closed 6 years ago

Get rid of the Thebes backed gfxContext in GLReadTexImageHelper, and the Thebes versions of gfxUtils::PremultiplyImageSurface/UnpremultiplyImageSurface and GLReadTexImageHelper::ReadPixelsIntoImageSurface/ReadScreenIntoImageSurface

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(1 file, 2 obsolete files)

I've got a patch to get rid of the Thebes backed gfxContext in GLReadTexImageHelper, and the Thebes versions of gfxUtils::PremultiplyImageSurface/UnpremultiplyImageSurface and GLReadTexImageHelper::ReadPixelsIntoImageSurface/ReadScreenIntoImageSurface.
Attached patch patch (obsolete) — Splinter Review
Attachment #8412990 - Flags: review?(matt.woodrow)
Attached patch patch (obsolete) — Splinter Review
Attachment #8412990 - Attachment is obsolete: true
Attachment #8412990 - Flags: review?(matt.woodrow)
Attachment #8413003 - Flags: review?(matt.woodrow)
Comment on attachment 8413003 [details] [diff] [review]
patch

Review of attachment 8413003 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxUtils.cpp
@@ +40,1 @@
>  {

Since there's only one caller to this function and it passes one param, we should get rid of the aDst parameter and remove a bunch of complexity from this function.

@@ +88,2 @@
>      for (uint32_t i = 0; i < dim; ++i) {
>  #ifdef IS_LITTLE_ENDIAN

We should also learn from bug 998742 and fix this up.
Attached patch patchSplinter Review
Attachment #8413003 - Attachment is obsolete: true
Attachment #8413003 - Flags: review?(matt.woodrow)
Attachment #8414299 - Flags: review?(matt.woodrow)
Depends on: 1003027
Attachment #8414299 - Flags: review?(matt.woodrow) → review+
Fixed by bug 1006198, I guess. (Some of patches there contain largely the same changes as the one here.)
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Depends on: 1006198
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.