1001687 - Get rid of the Thebes backed gfxContext in GLReadTexImageHelper, and the Thebes versions of gfxUtils::PremultiplyImageSurface/UnpremultiplyImageSurface and GLReadTexImageHelper::ReadPixelsIntoImageSurface/ReadScreenIntoImageSurface

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jonathan Watt [:jwatt]]

I've got a patch to get rid of the Thebes backed gfxContext in GLReadTexImageHelper, and the Thebes versions of gfxUtils::PremultiplyImageSurface/UnpremultiplyImageSurface and GLReadTexImageHelper::ReadPixelsIntoImageSurface/ReadScreenIntoImageSurface.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 3

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8413003 [details] [diff] [review]
patch

Review of attachment 8413003 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxUtils.cpp
@@ +40,1 @@
>  {

Since there's only one caller to this function and it passes one param, we should get rid of the aDst parameter and remove a bunch of complexity from this function.

@@ +88,2 @@
>      for (uint32_t i = 0; i < dim; ++i) {
>  #ifdef IS_LITTLE_ENDIAN

We should also learn from bug 998742 and fix this up.

Comment 4

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 5

[Jonathan Watt [:jwatt]]

Fixed by bug 1006198, I guess. (Some of patches there contain largely the same changes as the one here.)