1001702 - [B2G][1.4][l10n][E.ME] - The word "Homescreen" is not translated in any language in the Everything.Me and Smart Collection confirmation screens.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Joshua Mitchell (Inactive)]

Attachment: HS1.png

Description:
When adding an icon to the homescreen through e.me, The confirmation message has an untranslated "Homescreen" title. This also occurs on the "... has already been added to homescreen" message and the "Create your own Smart Collection" screen.

Repro Steps: (with language set to Albanian)
1) Update a Buri to BuildID: 20140423000203
2) Select the E.Me search bar and type in Social
3) Long press on "facebook" (example)
4) Observe confirmation screen
5) Long press on "facebook" again
6) Observe the already added screen
7) Select OK
8) Scroll to the right homescreen
9) Long-press empty screen
10) Select "Add smart collections"
11) Select Custom
Actual:
The word Homepage at the top of each message is untranslated.

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140423000203
Gaia: 25d53d442cbf17c150575c98979e957ae040e023
Gecko: 2d1b4d36eef9
Version: 30.0a2
Firmware Version: V1.2-device-cfg

Repro frequency: 100%
See attached: HS1.png, HS2.png
Link to failed test case: https://moztrap.mozilla.org/manage/case/12208/
https://moztrap.mozilla.org/manage/case/12214/
https://moztrap.mozilla.org/manage/case/12217/

Comment 1

[Joshua Mitchell (Inactive)]

Attachment: HS2.png

Comment 2

[Joshua Mitchell (Inactive)]

Does not occur in 1.3 as the title / header is new to 1.4
Environmental Variables:
Device: Buri 1.3 MOZ RIL
BuildID: 20140423024002
Gaia: fb2b8e25e8095a5db49b5eb68c74b49f180605d4
Gecko: da2500909f91
Version: 28.0
Firmware Version: V1.2-device.cfg

Comment 3

[Jason Smith [:jsmith]]

Looks like this is a untranslated string.

Comment 4

[Ran Ben Aharon [:ranbena] EverythingMe]

If I'm not mistaken this is a standard window.prompt which displays the invoking process name above the input text.
https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/everything.me/modules/CollectionsSuggest/CollectionsSuggest.js#L54

Comment 5

[bhavana bajaj [:bajaj]]

:gwagner do you have any ideas to resolve this issue without introducing new strings? Can we not re-use existing strings ?

Comment 6

[Rob MacDonald [:robmac]]

(In reply to bhavana bajaj [:bajaj] from comment #5)
> :gwagner do you have any ideas to resolve this issue without introducing new
> strings? Can we not re-use existing strings ?

Also flagging Francis for UX input.

Comment 7

[Gregor Wagner [:gwagner]]

Kevin, Mike, any ideas?

Comment 8

[Kevin Grandon :kgrandon]

Can we double check this is still an issue? I believe bug 999511 was uplifted two days ago and should fix this as well.

Comment 9

[Joshua Mitchell (Inactive)]

This IS still occurring on today's 1.4 Buri build

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140430000201
Gaia: 81e97c3ca58be0487292011bc59efa4cebab30be
Gecko: 123485e733d5
Version: 30.0
Firmware Version: v1.2-device.cfg

Comment 10

[Michael Henretty [:mikehenrty][:mhenretty]]

There are two parts to this bug. First, we need to have the translation for the homescreen app name in the webapp.manifest here [1].

Secondly, the app object which we use to fetch the app name from [2], does not get updated when we change locales. So, if you were to freshly flash 1.4 on a device, change the language to something other than the default (english), and then run through the STR, you will see this bug. But if you then reboot the device and run through the STR, the bug will not reproduce (provided you have an app name translation in the manifest, which I verified using French).

We will need to verify/fix both issues here.

1.) https://github.com/mozilla-b2g/gaia/blob/e665b1cfc7f809ebef954239fa643521ec1ec8bf/apps/homescreen/manifest.webapp#L22

2.) https://github.com/mozilla-b2g/gaia/blob/b59041c921efeab8d638eb627cac475443bfaec5/apps/system/js/app_modal_dialog.js#L385

Comment 11

[Candice Serran (:cserran)]

Given Michael's explanation in comment 10, who can take ownership of this bug?

Comment 12

[Gregor Wagner [:gwagner]]

Aus, can you take this?

Comment 13

[Aus Lacroix [:aus]]

Yes, I sure can.

1) I've verified that the application has a translation in it's manifest. If *must* have this app name translated in something other than Arabic, English, French, or Chinese I will need these from a translator.

2) It should be straightforward to update these values in the AppWindow when we detect a language change.

Comment 14

[Aus Lacroix [:aus]]

This looks to be a much simpler issue than expected. HomescreenWindow is not adding a listener for '_localized'. It's the only affected application.

This bug exists in master and 1.4. 1.3 is unaffected because the modal dialogs do not make use of titles.

Comment 15

[Aus Lacroix [:aus]]

Attachment: Pull Request - HomescreenWindow should listen for '_localized' event like AppWindow does by default.

Comment 16

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8419729 [details] [review]
Pull Request - HomescreenWindow should listen for '_localized' event like AppWindow does by default.

My bug, thanks!

Comment 17

[Aus Lacroix [:aus]]

Commit (master): https://github.com/mozilla-b2g/gaia/commit/c1a8cbaac1d921cfb50e3a2600720b75cf5afabd

Commit (v1.4): https://github.com/mozilla-b2g/gaia/commit/17fb44880e95bc7ae363a609d811bf5a9a067b5b

Fixed!

Comment 18

[Aus Lacroix [:aus]]

Clearing NI flags since we resolved the issue without futzing with the UX. :)

Comment 19

[Mike Livingston]

This issue has been fixed on the Buri 1.4 MOZ RIL

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140512000204
Gaia: 17fb44880e95bc7ae363a609d811bf5a9a067b5b
Gecko: ec24f847e7c0
Version: 30.0
Firmware Version: v1.2-device.cfg