Closed
Bug 1001759
Opened 10 years ago
Closed 10 years ago
Record total RAM and pagefile size in crash reports
Categories
(Core :: General, defect)
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: away, Assigned: away)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
2.63 KB,
patch
|
benjamin
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
This can help us understand what proportion of out-of-physical-memory errors come from too low pagefile settings. In my brief testing, ullTotalPageFile is the combined size of RAM + pagefile. Subtracting ullTotalPhys gets the size of the pagefile alone.
Attachment #8413091 -
Flags: review?(benjamin)
Updated•10 years ago
|
Attachment #8413091 -
Flags: review?(benjamin) → review+
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/62f2593a6412
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Comment on attachment 8413091 [details] [diff] [review] Patch Nominating in order to get more data faster. This isn't really a bugfix but it's very safe. [Approval Request Comment] Bug caused by (feature/regressing bug #): n/a, new code User impact if declined: Less OOM data Testing completed (on m-c, etc.): A few days on nightly, no issues on mozillazine Risk to taking this patch (and alternatives if risky): Very low risk, the data was already calculated, this patch is just logging String or IDL/UUID changes made by this patch: None
Attachment #8413091 -
Flags: approval-mozilla-beta?
Attachment #8413091 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
Updated•10 years ago
|
Attachment #8413091 -
Flags: approval-mozilla-beta?
Attachment #8413091 -
Flags: approval-mozilla-beta+
Attachment #8413091 -
Flags: approval-mozilla-aurora?
Attachment #8413091 -
Flags: approval-mozilla-aurora+
Comment 5•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/f76de0c8b3df https://hg.mozilla.org/releases/mozilla-beta/rev/4ee9435a9863
Updated•10 years ago
|
status-b2g-v1.4:
--- → fixed
Updated•10 years ago
|
Whiteboard: verifyme
Comment 7•10 years ago
|
||
Is there any need for manual testing here? If so can you offer some guidance?
Flags: needinfo?(dmajor)
Comment 8•10 years ago
|
||
dmajor did you file a socorro bug to have these fields whitelisted and search-indexed?
(In reply to Bogdan Maris, QA [:bogdan_maris] from comment #7) > Is there any need for manual testing here? If so can you offer some guidance? It's not really necessary, but if you want, you can load a crash report from a recent Win32 nightly and see that the "Metadata" tab has fields "TotalPageFile" and "TotalPhysicalMemory". (In reply to Benjamin Smedberg [:bsmedberg] from comment #8) > dmajor did you file a socorro bug to have these fields whitelisted and > search-indexed? Just opened bug 1006898.
Flags: needinfo?(dmajor)
Comment 10•10 years ago
|
||
(In reply to David Major [:dmajor] (UTC+12) from comment #9) > It's not really necessary, but if you want, you can load a crash report from > a recent Win32 nightly and see that the "Metadata" tab has fields > "TotalPageFile" and "TotalPhysicalMemory". Don't see any of those fields - 32.0a1 (2014-05-07), Win 7 x64. https://crash-stats.mozilla.com/report/index/196fec9e-ae8d-46bc-acd8-d07542140507
Flags: needinfo?(dmajor)
Assignee | ||
Comment 11•10 years ago
|
||
Ah, maybe it's restricted currently... you should be able to see them after bug 1006898 is fixed.
Flags: needinfo?(dmajor)
Comment 12•10 years ago
|
||
Removing "verifyme" keyword, since bug 1006898 is still open, while we got the Firefox 30 RC.
Keywords: verifyme
You need to log in
before you can comment on or make changes to this bug.
Description
•