Closed Bug 1001831 Opened 5 years ago Closed 5 years ago
Wrong text in new imip
Bar button strings
Just noticed that lightning.imipbar.btnDeclineRecurrences.tooltiptext in lightning.dtd has the wrong verb: "Accept" instead of "Decline". Trivial patch attached.
Humm... Forget the patch, although it is a trivial error and I wouldn't do it, L10n rules state that the entity name should change, which involves changes in .xul files, I'm afraid.
The (hopefully!) correct patch. Note, however, that I don't have the build system set up, so I haven't tested it myself.
There is another comment on the strings introduced with bug 990009 - see the comment #22 on that bug. It's about the usage of "event participation" in some strings instead of "event invitation", which would be more precise. I suggest to extend the patch here to those strings as well and change them accordingly.
I have changed the summary to reflect the need to further changes due to comment #3.
Component: Alarms → Lightning Only
Summary: Wrong text in lightning.imipbar.btnDeclineRecurrences.tooltiptext → Wrong text in new imipBar button strings
Extending Ricardos patch to replace "event participation" by "event invitation" in tooltip strings and also to change label for re-confirmation button. @Philipp: I guess we need to get this into the tree before the upcoming merge?
Comment on attachment 8413347 [details] [diff] [review] UpdateStringsOfNewImipBarButtons-V1.diff Review of attachment 8413347 [details] [diff] [review]: ----------------------------------------------------------------- r=philipp with these changes. It would be nice if we could get these in before the merge (which I fear is happening today), otherwise we'll have to announce late-l10n. ::: calendar/locales/en-US/chrome/lightning/lightning.dtd @@ +45,2 @@ > <!ENTITY lightning.imipbar.btnAcceptRecurrences.label "Accept all"> > +<!ENTITY lightning.imipbar.btnAcceptRecurrences2.tooltiptext "Accept event invitation for all recurrences of the event"> While we are here, I think it should be "...for all occurrences of the event" @@ +51,2 @@ > <!ENTITY lightning.imipbar.btnDeclineRecurrences.label "Decline all"> > +<!ENTITY lightning.imipbar.btnDeclineRecurrences2.tooltiptext "Decline event invitation for all recurrences of the event"> Same here @@ +55,5 @@ > <!ENTITY lightning.imipbar.btnDetails.label "Details…"> > <!ENTITY lightning.imipbar.btnDetails.tooltiptext "Show event details"> > <!ENTITY lightning.imipbar.btnMore.label "More"> > <!ENTITY lightning.imipbar.btnMore.tooltiptext "Click to show more options"> > +<!ENTITY lightning.imipbar.btnReconfirm2.label "Re-confirm"> Reconfirm is written without a - @@ +63,2 @@ > <!ENTITY lightning.imipbar.btnTentativeRecurrences.label "Tentative all"> > +<!ENTITY lightning.imipbar.btnTentativeRecurrences2.tooltiptext "Accept event invitation tentatively for all recurrences of the event"> occurrences
Attachment #8413347 - Flags: review?(philipp) → review+
Philipp, can you take care to update and checkin the patch, please. I have a system crash here an won't be able to do so shorterm, so we would end up with a late l10n otherwise for sure. Thank you.
Patch for checkin
Pushed to comm-central changeset c3d5f07afddd
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.3
Thu May 01 2014 23:18:14 Error: undefined entity Source file: chrome://lightning/content/imip-bar-overlay.xul Line: 157, Column: 19 Source code: <menuitem id="imipAcceptRecurrencesButton_Tentative" tooltiptext="&lightning.imipbar.btnTentativeRecurrences.tooltiptext;" should be: tooltiptext="&lightning.imipbar.btnTentativeRecurrences2.tooltiptext;"
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
Depends on: 1003137
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.