Closed Bug 1001866 Opened 10 years ago Closed 10 years ago

Use the new Australis toolbar button style for messengercompose.css on OS X.

Categories

(Thunderbird :: Theme, defect)

Product:
Thunderbird
Component:
Theme
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 31.0

People

(Reporter: jsbruner, Assigned: jsbruner)

Details

Attachments

(1 file, 5 obsolete files)

Final Patch.
31.16 KB, patch
jsbruner
: review+
Details | Diff | Splinter Review
Attached patch Patch. (obsolete) — — Splinter Review
Bug 980491, but for the compose window.
Comment on attachment 8413216 [details] [diff] [review] Patch. Review of attachment 8413216 [details] [diff] [review]: ----------------------------------------------------------------- Richard, I'd like to get this in for TB 31, so please try to review this quickly. Thanks!
Attachment #8413216 - Flags: review?(richard.marti)
Summary: Use the new Australis toolbar button style for messengercompose.css → Use the new Australis toolbar button style for messengercompose.css on OS X.
Attached patch Patch. (obsolete) — — Splinter Review
I had extra whitespace.
Assignee: nobody → josiah
Attachment #8413216 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8413216 - Flags: review?(richard.marti)
Attachment #8413217 - Flags: review?(richard.marti)
Comment on attachment 8413217 [details] [diff] [review] Patch. Review of attachment 8413217 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. The only difference to the main window buttons are the different margins and paddings. With this fixed r=me. To fix the margin, please add this rule: http://mxr.mozilla.org/comm-central/source/mail/themes/osx/mail/primaryToolbar.css#137 and: http://mxr.mozilla.org/comm-central/source/mail/themes/osx/mail/compose/messengercompose.css#132 The padding change is below ::: mail/themes/osx/mail/compose/messengercompose.css @@ +54,4 @@ > .toolbarbutton-1 > .toolbarbutton-menubutton-button, > .toolbarbutton-1 > .toolbarbutton-menubutton-dropmarker { > height: 22px; > + padding: 0px; Please use: padding: 0 4px;
Attachment #8413217 - Flags: review?(richard.marti) → review+
More testing showed me the #button-contacts in checked=true shows the blue icon and text. Please remove this too.
Attached patch Patch. (obsolete) — — Splinter Review
Thanks.
Attachment #8413217 - Attachment is obsolete: true
Attachment #8413264 - Flags: review+
Keywords: checkin-needed
Oh, didn't see your last comment.
Keywords: checkin-needed
Attached patch Patch. (obsolete) — — Splinter Review
There we go.
Attachment #8413264 - Attachment is obsolete: true
Attachment #8413265 - Flags: review+
Keywords: checkin-needed
Attached patch Patch. (obsolete) — — Splinter Review
We don't need that padding on the toolbar actually.
Attachment #8413265 - Attachment is obsolete: true
Attachment #8413269 - Flags: review+
Attached patch Final Patch. — — Splinter Review
I removed the blue icon in compose-toolbar.png and the @2x version of it.
Attachment #8413269 - Attachment is obsolete: true
Attachment #8413270 - Flags: review+
https://hg.mozilla.org/comm-central/rev/11089a6b1153
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 31.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: