Closed Bug 1001869 Opened 10 years ago Closed 10 years ago

Use the new Australis toolbar button style for the AB on OS X.

Categories

(Thunderbird :: Theme, defect)

All
macOS
defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 31.0

People

(Reporter: jsbruner, Assigned: jsbruner)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch newStyleForAB.patch (obsolete) — Splinter Review
Bug 980491, but for the AB.
Attachment #8413220 - Flags: review?(richard.marti)
Assignee: nobody → josiah
Status: NEW → ASSIGNED
Comment on attachment 8413220 [details] [diff] [review]
newStyleForAB.patch

Review of attachment 8413220 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. The only difference to the main window buttons are the different margins and paddings. With this fixed r=me.

To fix the margin, please add this rule:
http://mxr.mozilla.org/comm-central/source/mail/themes/osx/mail/primaryToolbar.css#137
and remove line:
http://mxr.mozilla.org/comm-central/source/mail/themes/osx/mail/addrbook/addressbook.css#109

The padding change is below

Please could you also add the lines
http://mxr.mozilla.org/comm-central/source/mail/themes/osx/mail/primaryToolbar.css#103
to
http://mxr.mozilla.org/comm-central/source/mail/themes/osx/mail/primaryToolbar.css#117 ?

I know it isn't used in TB but a Add-on could use this and would look then correct.

::: mail/themes/osx/mail/addrbook/addressbook.css
@@ +30,4 @@
>  .toolbarbutton-1 > .toolbarbutton-menubutton-button,
>  .toolbarbutton-1 > .toolbarbutton-menubutton-dropmarker {
>    height: 22px;
> +  padding: 0px;

Please use:
padding: 0 4px;
Attachment #8413220 - Flags: review?(richard.marti) → review+
Attached patch Patch.Splinter Review
Addressed comments.
Attachment #8413220 - Attachment is obsolete: true
Attachment #8413268 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/9de04a348c2c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 31.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: