Closed Bug 1001987 Opened 6 years ago Closed 6 years ago

Make MOZ_STATIC_ASSERT_VALID_ARG_COUNT compatible with ICC

Categories

(Core :: MFBT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: poiru, Assigned: poiru)

Details

Attachments

(1 file, 1 obsolete file)

User zhoubcfan let me know via email that bug 900908 broke compilation when using the Intel C++ (version 14.0.2.176) compiler:

/mozilla-central/image/src/imgLoader.cpp(215): error: expression must have integral or enum type
  NS_IMPL_ISUPPORTS1(imgMemoryReporter, nsIMemoryReporter)
  ^
Apparently ICC expects the static_assert condition to be an integral constant expression.
Attachment #8413343 - Flags: review?(jwalden+bmo)
I can confirm that the patch works. Again, thanks!
Comment on attachment 8413343 [details] [diff] [review]
Make MOZ_STATIC_ASSERT_VALID_ARG_COUNT compatible with ICC

Review of attachment 8413343 [details] [diff] [review]:
-----------------------------------------------------------------

Oh!  I forgot about the prohibitions on floating point math in ICEs.  Makes sense, should have thought of this before.
Attachment #8413343 - Flags: review?(jwalden+bmo) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/bae0d4946901
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.