Closed
Bug 1001987
Opened 10 years ago
Closed 10 years ago
Make MOZ_STATIC_ASSERT_VALID_ARG_COUNT compatible with ICC
Categories
(Core :: MFBT, defect)
Core
MFBT
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: poiru, Assigned: poiru)
Details
Attachments
(1 file, 1 obsolete file)
2.85 KB,
patch
|
poiru
:
review+
|
Details | Diff | Splinter Review |
User zhoubcfan let me know via email that bug 900908 broke compilation when using the Intel C++ (version 14.0.2.176) compiler: /mozilla-central/image/src/imgLoader.cpp(215): error: expression must have integral or enum type NS_IMPL_ISUPPORTS1(imgMemoryReporter, nsIMemoryReporter) ^
Assignee | ||
Comment 1•10 years ago
|
||
Apparently ICC expects the static_assert condition to be an integral constant expression.
Attachment #8413343 -
Flags: review?(jwalden+bmo)
Comment 2•10 years ago
|
||
I can confirm that the patch works. Again, thanks!
Comment 3•10 years ago
|
||
Comment on attachment 8413343 [details] [diff] [review] Make MOZ_STATIC_ASSERT_VALID_ARG_COUNT compatible with ICC Review of attachment 8413343 [details] [diff] [review]: ----------------------------------------------------------------- Oh! I forgot about the prohibitions on floating point math in ICEs. Makes sense, should have thought of this before.
Attachment #8413343 -
Flags: review?(jwalden+bmo) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8413343 -
Attachment is obsolete: true
Attachment #8413756 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bae0d4946901
Keywords: checkin-needed
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bae0d4946901
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•