Closed Bug 1001998 Opened 10 years ago Closed 9 years ago

RTL Button List (fake select) value is truncated from the right.

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: nefzaoui, Assigned: pivanov)

References

Details

(Keywords: verifyme)

Attachments

(1 file)

patch for Gaia/master
46 bytes, text/x-github-pull-request
arnau
: review+
nefzaoui
: feedback+
Details | Review 
RTL Button List (fake select) value position is not correct.
Blocks: gaia-rtl
Summary: RTL Button List (fake select) value position is not correct. → RTL Button List (fake select) value is truncated from the right.
Assignee: nobody → pivanov
Attached file patch for Gaia/master — 
I also fix some small issue with `dark-skin select` element there was double text in select box (both LTR and RTL)
Attachment #8450079 - Flags: feedback?(nefzaoui.ahmed)
Comment on attachment 8450079 [details] [review]
patch for Gaia/master

This also LGTM from a RTL POV
Attachment #8450079 - Flags: feedback?(nefzaoui.ahmed) → feedback+
Attachment #8450079 - Flags: review?(rnowmrch)
Comment on attachment 8450079 [details] [review]
patch for Gaia/master

Looks good, thanks Pavel
Attachment #8450079 - Flags: review?(rnowmrch) → review+
Thanks :) 

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/1cdaf2771a9835c604a393cdb752805d5e6bcbac
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Mass Edit: adding the [rtl-meta]
Whiteboard: [rtl-meta]
QA Whiteboard: [rtl-impact]
Whiteboard: [rtl-meta]
Keywords: verifyme
Hi Ahmed
Please provide detail reproduce steps or picture to tester for verification.Thanks for help.
Flags: needinfo?(nefzaoui.ahmed)
Hi Ahmed,
Could you please provide detail reproduce steps or picture to tester for verification. Thanks for help.
Flags: needinfo?(nefzaoui.ahmed) → needinfo?(nefzaoui)
Flags: needinfo?(nefzaoui)
You need to log in before you can comment on or make changes to this bug.