1002039 - Cannot find virtualenv.py to setup marionette environment

Status: RESOLVED FIXED

(Testing :: Marionette Client and Harness, defect)

Description

[Michael Vines [:m1] [:evilmachines]]

http://mxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/venv_automation.sh#22 pulls virtualenv.py from a now non-functioning github URL.

The fix looks to be just:
-  curl https://raw.github.com/pypa/virtualenv/${VIRTUAL_ENV_VERSION}/virtualenv.py | ${PYTHON} - marionette_auto_venv 
+  curl https://raw.githubusercontent.com/pypa/virtualenv/${VIRTUAL_ENV_VERSION}/virtualenv.py | ${PYTHON} - marionette_auto_venv

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

No, the URL is correct but curl should follow the redirect. So adding -L before the PIPE will fix it.

Comment 2

[Michael Vines [:m1] [:evilmachines]]

Ah, yeah that's nicer :)

Comment 3

[Malini Das [:mdas] - Away, not checking bugmail]

out of curiosity, are you using venv_automation.sh?

Comment 4

[Malini Das [:mdas] - Away, not checking bugmail]

and what is it being used for?

Comment 5

[Michael Vines [:m1] [:evilmachines]]

Yeah, we are.  Aren't you? :)

We use it to setup the virtual env that all our Marionette-based tests run out of.

Comment 6

[Malini Das [:mdas] - Away, not checking bugmail]

(In reply to Michael Vines [:m1] [:evilmachines] from comment #5)
> Yeah, we are.  Aren't you? :)

Not for a while, we use mozharness to set up our environments in tbpl, or jenkins scripts that invoke virtualenv directly in other automation.
> 
> We use it to setup the virtual env that all our Marionette-based tests run
> out of.

Interesting! I just wanted to know its current usecases, thanks.

Comment 7

[Michael Vines [:m1] [:evilmachines]]

Attachment: -L x 3

I think I got 'em all.

Comment 8

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 8414200 [details] [diff] [review]
-L x 3

Review of attachment 8414200 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, thanks!

Comment 9

[Malini Das [:mdas] - Away, not checking bugmail]

pushed to m-i:
https://hg.mozilla.org/integration/mozilla-inbound/rev/66eeca26b328

Comment 10

[Malini Das [:mdas] - Away, not checking bugmail]

Does this need to be pushed to any other branches?

Comment 11

[Michael Vines [:m1] [:evilmachines]]

Comment on attachment 8414200 [details] [diff] [review]
-L x 3

NOTE: This flag is now for security issues only. Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): github.com adding a HTTP redirect to their raw URLs
User impact if declined:  NPOTB.  Our B2G tests will continue to be blocked (without a locally patched Gecko).
Testing completed:  Yes
Risk to taking this patch (and alternatives if risky):  Our B2G tests will become unblocked and we may find new issues or regressions, which could have a negative impact on the v1.3+ bug burndown rate.
String or UUID changes made by this patch: n/a

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/66eeca26b328

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8414200 [details] [diff] [review]
-L x 3

This is test-only, so it doesn't need extra approval.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/6320d36c81ed
https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/4b68615ea3e5

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Moving bugs for Marionette client due to component changes.