Closed
Bug 1002039
Opened 10 years ago
Closed 10 years ago
Cannot find virtualenv.py to setup marionette environment
Categories
(Testing :: Marionette Client and Harness, defect)
Tracking
(blocking-b2g:1.3+, firefox30 wontfix, firefox31 wontfix, firefox32 fixed, b2g-v1.3 fixed, b2g-v1.3T fixed, b2g-v1.4 fixed, b2g-v2.0 fixed)
People
(Reporter: m1, Assigned: m1)
Details
(Keywords: pi-marionette-client, pi-marionette-runner)
Attachments
(1 file)
3.28 KB,
patch
|
mdas
:
review+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/venv_automation.sh#22 pulls virtualenv.py from a now non-functioning github URL. The fix looks to be just: - curl https://raw.github.com/pypa/virtualenv/${VIRTUAL_ENV_VERSION}/virtualenv.py | ${PYTHON} - marionette_auto_venv + curl https://raw.githubusercontent.com/pypa/virtualenv/${VIRTUAL_ENV_VERSION}/virtualenv.py | ${PYTHON} - marionette_auto_venv
Comment 1•10 years ago
|
||
No, the URL is correct but curl should follow the redirect. So adding -L before the PIPE will fix it.
Assignee | ||
Comment 2•10 years ago
|
||
Ah, yeah that's nicer :)
Comment 3•10 years ago
|
||
out of curiosity, are you using venv_automation.sh?
Comment 4•10 years ago
|
||
and what is it being used for?
Assignee | ||
Comment 5•10 years ago
|
||
Yeah, we are. Aren't you? :) We use it to setup the virtual env that all our Marionette-based tests run out of.
Comment 6•10 years ago
|
||
(In reply to Michael Vines [:m1] [:evilmachines] from comment #5) > Yeah, we are. Aren't you? :) Not for a while, we use mozharness to set up our environments in tbpl, or jenkins scripts that invoke virtualenv directly in other automation. > > We use it to setup the virtual env that all our Marionette-based tests run > out of. Interesting! I just wanted to know its current usecases, thanks.
Updated•10 years ago
|
Keywords: ateam-marionette-client,
ateam-marionette-runner
Comment 8•10 years ago
|
||
Comment on attachment 8414200 [details] [diff] [review] -L x 3 Review of attachment 8414200 [details] [diff] [review]: ----------------------------------------------------------------- lgtm, thanks!
Attachment #8414200 -
Flags: review?(mdas) → review+
Comment 9•10 years ago
|
||
pushed to m-i: https://hg.mozilla.org/integration/mozilla-inbound/rev/66eeca26b328
Comment 10•10 years ago
|
||
Does this need to be pushed to any other branches?
Assignee | ||
Comment 11•10 years ago
|
||
Comment on attachment 8414200 [details] [diff] [review] -L x 3 NOTE: This flag is now for security issues only. Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] Bug caused by (feature/regressing bug #): github.com adding a HTTP redirect to their raw URLs User impact if declined: NPOTB. Our B2G tests will continue to be blocked (without a locally patched Gecko). Testing completed: Yes Risk to taking this patch (and alternatives if risky): Our B2G tests will become unblocked and we may find new issues or regressions, which could have a negative impact on the v1.3+ bug burndown rate. String or UUID changes made by this patch: n/a
Attachment #8414200 -
Flags: approval-mozilla-b2g28?
Comment 12•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/66eeca26b328
Assignee: nobody → mvines
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Comment 13•10 years ago
|
||
Comment on attachment 8414200 [details] [diff] [review] -L x 3 This is test-only, so it doesn't need extra approval.
Attachment #8414200 -
Flags: approval-mozilla-b2g28?
Comment 14•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/6320d36c81ed https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/4b68615ea3e5
status-b2g-v1.3T:
--- → affected
status-b2g-v2.0:
--- → fixed
status-firefox30:
--- → wontfix
status-firefox31:
--- → wontfix
status-firefox32:
--- → fixed
Updated•10 years ago
|
Updated•1 year ago
|
Product: Testing → Remote Protocol
Comment 15•1 year ago
|
||
Moving bugs for Marionette client due to component changes.
Component: Marionette → Marionette Client and Harness
Product: Remote Protocol → Testing
You need to log in
before you can comment on or make changes to this bug.
Description
•