Closed Bug 1002086 Opened 10 years ago Closed 10 years ago

UpdateService uses the non-existent nsIAddonUpdateCheckListener interface

Categories

(Toolkit :: Application Update, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: ehsan.akhgari, Assigned: robert.strong.bugs)

References

Details

Attachments

(1 file, 1 obsolete file)

Depends on: 1002088
Attached patch patch rev1 (obsolete) — Splinter Review
Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED
Attachment #8413436 - Flags: review?(ehsan)
Comment on attachment 8413436 [details] [diff] [review]
patch rev1

Review of attachment 8413436 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!  I checked to see if any of the methods in http://www.oxymoronical.com/experiments/apidocs/interface/nsIAddonUpdateCheckListener are implemented in nsUpdateService.js but couldn't find any of them, so this looks good.  When I was doing these checks I found this <http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/nsUpdateService.js#2935> where the name of the function passed to LOG() is invalid.  Feel free to fix it if you can while you're here, but I don't care much about that either way.  :-)
Attachment #8413436 - Flags: review?(ehsan) → review+
Thanks!
Attachment #8413436 - Attachment is obsolete: true
Attachment #8413446 - Flags: review+
Pushed to fx-team
https://hg.mozilla.org/integration/fx-team/rev/cebe712acbab
Flags: in-testsuite-
Target Milestone: --- → mozilla31
Is it just me, or is the whitespace screwy on the first hunk? I.e. tabs instead of spaces?
Flags: needinfo?(robert.strong.bugs)
meh, that snuck in. I'll followup
Flags: needinfo?(robert.strong.bugs)
You need to log in before you can comment on or make changes to this bug.