Closed Bug 1002267 Opened 6 years ago Closed 6 years ago

Intermittent test_add_remove_handlers (test_structured.TestStructuredLog) AssertionError: 1398630837812 != 1398630838402.603 within 100 delta

Categories

(Testing :: Mozbase, defect)

x86
Linux
defect
Not set

Tracking

(firefox30 fixed, firefox31 fixed, firefox32 fixed, firefox-esr24 unaffected, b2g-v1.4 fixed, b2g-v2.0 fixed)

RESOLVED FIXED
mozilla32
Tracking Status
firefox30 --- fixed
firefox31 --- fixed
firefox32 --- fixed
firefox-esr24 --- unaffected
b2g-v1.4 --- fixed
b2g-v2.0 --- fixed

People

(Reporter: RyanVM, Assigned: jgraham)

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

https://tbpl.mozilla.org/php/getParsedLog.php?id=38591060&tree=Mozilla-Central

Linux mozilla-central build on 2014-04-27 12:14:26 PDT for push 63bbdca27a53
slave: bld-linux64-spot-463

======================================================================
FAIL: test_add_remove_handlers (test_structured.TestStructuredLog)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builds/slave/m-cen-lx-000000000000000000000/build/testing/mozbase/mozlog/tests/test_structured.py", line 146, in test_add_remove_handlers
    "message": "test1"})
  File "/builds/slave/m-cen-lx-000000000000000000000/build/testing/mozbase/mozlog/tests/test_structured.py", line 46, in assert_log_equals
    self.assertAlmostEqual(actual["time"], time.time()*1000, delta=100)
AssertionError: 1398630837812 != 1398630838402.603 within 100 delta

----------------------------------------------------------------------
Ran 339 tests in 106.156s

FAILED (failures=1, skipped=18)
https://tbpl.mozilla.org/php/getParsedLog.php?id=38603819&tree=Mozilla-Inbound

Well, this is going to be fun being an essentially unstarrable TBPL error. CCing the other sheriffs so they don't waste time filing dupes on each different variation of the AssertionFailure. Also, why aren't the test names displaying in the failure message per the visibility guidelines?
Did this just start failing? It seems pretty weird that it would suddenly take 800ms to execute a few lines of code.

Anyway I can of course increase the allowed delta or just remove the test that isn't that useful anyway. But it's quite strange that it should fail quite so badly.
Attachment #8413820 - Flags: review?(ahalberstadt)
Attachment #8413820 - Flags: review?(ahalberstadt) → review?(wlachance)
Comment on attachment 8413820 [details] [diff] [review]
Stop trying to compare times in the mozlog unit tests.

Yeah, we shouldn't rely on timing in correctness tests. Assume anything could happen.
Attachment #8413820 - Flags: review?(wlachance) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/246b181357c2
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.