Closed
Bug 1002277
Opened 10 years ago
Closed 10 years ago
Bug 984537 broke non-ion builds
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: stevensn, Assigned: stevensn)
References
Details
(Whiteboard: [qa-] )
Attachments
(1 file)
1.05 KB,
patch
|
bhackett1024
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Bug 984537 broke non-ion builds /media/nfs/usb_drive_src/firefox/mozilla-central-hg/src/js/src/jsgc.cpp: In function ‘bool BeginMarkPhase(JSRuntime*)’: 7:34.45 /media/nfs/usb_drive_src/firefox/mozilla-central-hg/src/js/src/jsgc.cpp:2774:35: error: ‘TopmostJitActivationCompartment’ is not a member of ‘js::jit’ 7:34.45 In file included from /home/ssinger/build-out.ppc64/js/src/Unified_cpp_js_src2.cpp:184:0:
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8413461 -
Flags: review?(bhackett1024)
Updated•10 years ago
|
Attachment #8413461 -
Flags: review?(bhackett1024) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/31929d871cad
Assignee: nobody → steve
Keywords: checkin-needed
Comment 3•10 years ago
|
||
(In reply to Carsten Book [:Tomcat] from comment #2) > https://hg.mozilla.org/integration/mozilla-inbound/rev/31929d871cad sorry had to back this out since i was thinking this caused a mochitest dt3 orange. But turned out that a push from jandem caused this, so re-checkedin this as https://hg.mozilla.org/integration/mozilla-inbound/rev/0014c1997618
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0014c1997618
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Assignee | ||
Updated•10 years ago
|
status-firefox31:
--- → affected
status-firefox32:
--- → affected
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8413461 [details] [diff] [review] 1002277_fix_nonion.diff [Approval Request Comment] Bug caused by (feature/regressing bug #): Bug 984537 User impact if declined: non asmjs architectures won't build Testing completed (on m-c, etc.): tested on m-c Risk to taking this patch (and alternatives if risky): low, just adding an #ifdef that is NPOTB-tier1 String or IDL/UUID changes made by this patch:
Attachment #8413461 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
Updated•10 years ago
|
Attachment #8413461 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•