1002291 - [Camera] Setting.configure weak check if a variable is an array

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Diego Marcos [:dmarcos]]

Checking if the attribute length is defined is weak. We should be doing the following:

Object.prototype.toString.call(o) === '[object Array]'

Explanation here:

http://perfectionkills.com/instanceof-considered-harmful-or-how-to-write-a-robust-isarray/

Comment 1

[Wilson Page [:wilsonpage]]

Or `Array.isArray(o)`

I need a little bit more info on what line you're talking about. I believe the intention is to see if there are any options defined in the settings config.

Comment 2

[Wilson Page [:wilsonpage]]

That is, I don't think the length check is specifically to check that `options` is an Array. We're just making the assumption that it is.

Comment 3

[Mike Habicher [:mikeh] (high bugzilla latency)]

Any progress on this issue? Is it even an issue?