Closed Bug 1002293 Opened 6 years ago Closed 6 years ago
CI fixes for travis
We should remove the requirement for sudo in our travis scripts. Relevant commits: https://github.com/henrikhodne-test/gaia/commit/24ef03b19be30a2374cb17580bbfbf30a79c4ddf https://github.com/henrikhodne-test/gaia/commit/ff308fcf759dfd506168bcf96900eaad48944695 https://github.com/henrikhodne-test/gaia/commit/88773a1f5915e4c2375382b96f9bca5be9f99dc2
This is the first of two pull requests I'm opening for this, another one is coming to the main gaia repository very soon.
Attachment #8414077 - Flags: review?(kgrandon)
Comment on attachment 8414077 [details] [review] travis-project-jobs pull request Going to forward to James as he is the main maintainer of this module.
Attachment #8414077 - Flags: review?(kgrandon) → review?(jlal)
And thanks for the patch! =)
Here's the second pull request (sorry if I'm doing this part wrong, haven't used Bugzilla in a while).
Attachment #8414082 - Flags: review?(kgrandon)
Comment on attachment 8414082 [details] [review] gaia pull request Thanks! Yuren, James - Mind if I forward this pull request onto you to review? The goal here is to get rid of sudo access in our CI scripts.
Attachment #8414082 - Flags: review?(kgrandon) → review?(yurenju.mozilla)
Will take a look tomorrow PST
Comment on attachment 8414082 [details] [review] gaia pull request henrik, we got some error on travis, could you take a look? thanks! set me review flag again if you have updated pr and travis is passed.
Pull request with $PATH update: https://github.com/mozilla-b2g/travis-project-jobs/pull/4
Here is a pull request against gaia with the $PATH update: https://github.com/mozilla-b2g/gaia/pull/19048
Yuren - can you try reviewing this one? Thanks!
Attachment #8419205 - Flags: review?(yurenju.mozilla)
Comment on attachment 8419205 [details] [review] Github pull request Hopefully Yuren won't be mad that I r+'ed this! Sorry for taking forever to look at this thanks to Travis Team & Kevin for fixing this up.
Attachment #8419205 - Flags: review?(yurenju.mozilla) → review+
I think that's fine, thanks a lot! :)
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Comment on attachment 8414077 [details] [review] travis-project-jobs pull request we landed these fixes
Attachment #8414077 - Flags: review?(jlal)
You need to log in before you can comment on or make changes to this bug.