Closed Bug 1002293 Opened 6 years ago Closed 6 years ago

CI fixes for travis

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kgrandon, Assigned: henrik)

Details

Attachments

(3 files)

57 bytes, text/x-github-pull-request
Details | Review
46 bytes, text/x-github-pull-request
Details | Review
46 bytes, text/x-github-pull-request
jlal
: review+
Details | Review
This is the first of two pull requests I'm opening for this, another one is coming to the main gaia repository very soon.
Attachment #8414077 - Flags: review?(kgrandon)
Comment on attachment 8414077 [details] [review]
travis-project-jobs pull request

Going to forward to James as he is the main maintainer of this module.
Attachment #8414077 - Flags: review?(kgrandon) → review?(jlal)
And thanks for the patch! =)
Attached file gaia pull request
Here's the second pull request (sorry if I'm doing this part wrong, haven't used Bugzilla in a while).
Attachment #8414082 - Flags: review?(kgrandon)
Comment on attachment 8414082 [details] [review]
gaia pull request

Thanks! Yuren, James - Mind if I forward this pull request onto you to review?

The goal here is to get rid of sudo access in our CI scripts.
Attachment #8414082 - Flags: review?(kgrandon) → review?(yurenju.mozilla)
Attachment #8414082 - Flags: review?(jlal)
Assignee: kgrandon → henrik
Will take a look tomorrow PST
Comment on attachment 8414082 [details] [review]
gaia pull request

henrik, we got some error on travis, could you take a look? thanks!

set me review flag again if you have updated pr and travis is passed.
Attachment #8414082 - Flags: review?(yurenju.mozilla)
Attachment #8414082 - Flags: review?(jlal)
Here is a pull request against gaia with the $PATH update: https://github.com/mozilla-b2g/gaia/pull/19048
Attached file Github pull request
Yuren - can you try reviewing this one? Thanks!
Attachment #8419205 - Flags: review?(yurenju.mozilla)
Comment on attachment 8419205 [details] [review]
Github pull request

Hopefully Yuren won't be mad that I r+'ed this! Sorry for taking forever to look at this thanks to Travis Team & Kevin for fixing this up.
Attachment #8419205 - Flags: review?(yurenju.mozilla) → review+
I think that's fine, thanks a lot! :)
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Comment on attachment 8414077 [details] [review]
travis-project-jobs pull request

we landed these fixes
Attachment #8414077 - Flags: review?(jlal)
You need to log in before you can comment on or make changes to this bug.