Closed
Bug 1002383
Opened 10 years ago
Closed 10 years ago
Mark fallback cache entries correctly
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: lanker, Assigned: lanker)
Details
Attachments
(1 file)
1.77 KB,
patch
|
ochameau
:
review+
|
Details | Diff | Splinter Review |
storeCache is async, so at the time markEntry was run for fallback items, the cache entry might not exist yet which led to that the fallback entries were not properly marked. This could later on trigger an assert when nsHttpChannel::ProcessFallback was run. With this change we now send the proper type directly to storeCache.
Assignee | ||
Updated•10 years ago
|
Component: Networking: Cache → General
Product: Core → Firefox OS
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8413626 -
Flags: review?(poirot.alex)
Comment 2•10 years ago
|
||
Comment on attachment 8413626 [details] [diff] [review] Bug_1002383-Mark-fallback-cache-entries-correctly.patch Review of attachment 8413626 [details] [diff] [review]: ----------------------------------------------------------------- Good catch, Thanks! Tested against accuweather from telefonic repo.
Attachment #8413626 -
Flags: review?(poirot.alex) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/a4747f7827a9
Assignee: nobody → fredrik.lanker
Keywords: checkin-needed
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a4747f7827a9
Status: UNCONFIRMED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•