Closed Bug 1002383 Opened 5 years ago Closed 5 years ago

Mark fallback cache entries correctly

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: lanker, Assigned: lanker)

Details

Attachments

(1 file)

storeCache is async, so at the time markEntry was run for fallback items, the cache entry might not exist yet which led to that the fallback entries were not properly marked. This could later on trigger an assert when nsHttpChannel::ProcessFallback was run. With this change we now send the proper type directly to storeCache.
Component: Networking: Cache → General
Product: Core → Firefox OS
Comment on attachment 8413626 [details] [diff] [review]
Bug_1002383-Mark-fallback-cache-entries-correctly.patch

Review of attachment 8413626 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch, Thanks!

Tested against accuweather from telefonic repo.
Attachment #8413626 - Flags: review?(poirot.alex) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a4747f7827a9
Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.