1002415 - Imip bar button type is not adjusted automatically

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect, P1)

Description

[[:MakeMyDay]]

The automated type adjusting of new imipbar buttons is currently broken. There is a related error log message and I already have a fix for this. Due to a system crash it may take some days to provide it.

Comment 1

[Stefan Sitter [:ssitter]]

Could you please provide the related error message here or add it to the summary to ensure this bug shows up when searching using the error message as input.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

When your systems are up again, maybe it would make sense to write a mozmill test for this too.

Comment 3

[[:MakeMyDay]]

Attachment: FixBrokenAutomatedImipBarButtonAdjusting-V1.diff

If the merge alreday was done, requesting approval for aurora as well.

Comment 4

[[:MakeMyDay]]

Forgot to post the error message:

[JavaScript Error: "[Exception... "[JavaScript Error: "document.getElementById(...) is null" {file: "chrome://lightning/content/imip-bar.js" line: 138}]'[JavaScript Error: "document.getElementById(...) is null" {file: "chrome://lightning/content/imip-bar.js" line: 138}]' when calling method: [calIOperationListener::onOperationComplete]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///C:/Mozilla/Debugging/Thunderbird/Profiles/unstable/central/Test-central-en/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/components/calCompositeCalendar.js :: calCompositeGetListenerHelper.prototype.onOperationComplete :: line 520"  data: yes]"]

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8414452 [details] [diff] [review]
FixBrokenAutomatedImipBarButtonAdjusting-V1.diff

Review of attachment 8414452 [details] [diff] [review]:
-----------------------------------------------------------------

r/a=philipp

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Could you file a new bug to write a mozmill test for this?

Comment 7

[[:MakeMyDay]]

Done, see bug 1003207. And sorry for the typo ;-)

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/65dd73825280
https://hg.mozilla.org/releases/comm-aurora/rev/287d35b00ecf