1002434 - App review history missing

Status: VERIFIED FIXED

(Marketplace Graveyard :: Reviewer Tools, defect, P2)

Description

[Andrew Williamson [:eviljeff]]

If you compare:
https://marketplace.firefox.com/reviewers/apps/review/line
and 
https://marketplace.firefox.com/developers/app/line/status
You see that the earliest version in the review history is 1.0.4 but the status page confirms there were at least 7 earlier versions (at least because deleted versions aren't shown in the developer status page, but are supposed to be in the review history).

Given that this history may contain an important record of what happened previously with an app, we absolutely need to be able to view it.

Comment 1

[Mathieu Pillard [:mat]]

What happens in this:
- In the view/template, we load the 10 last versions
- We also load independently of that the list of all versions and the associated commbadge thread id, in an XHR, and then load the commbadge data for each thread
- Inside each commbadge thread, pagination is handled in JavaScript

So we already have working pagination for each commbadge thread, and we already load the list of versions, so I think we should move the entire app history to JavaScript instead of the current mix of hardcoded in template + JavaScript. As a bonus, we could be smarter about the XHR to commbadge we make, since at the moment we load commbadge data for versions we'll never show.

Comment 2

[Kevin Ngo [:ngoke]]

Was planning on working on this since I have an idea of what'll it look like. I have a dupe at https://bugzilla.mozilla.org/show_bug.cgi?id=1095605

Currently, we aren't loading Commbadge data for versions we never show. We now only load data for the threads that exist in the template.

To fix: for threads, we can use Django pagination. And keep using Commbadge XHRs to populate the notes.

Comment 4

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/f60295d307d62c2f70d239199e708e57228af311

STR:
- Look at a packaged app in reviewer tools with a lot of versions (more than 10)
- Make sure there is pagination in the app review page for the versions, and that it works correctly (including developer/reviewer discussion for each version when it exists)

Comment 5

[Madalin Cotetiu]

Verified as fixed in FF39(Win7) in marketplace-dev.allizom.org
Screencast for this issue:  http://screencast.com/t/hhoWprxK
Closing bug.