Footgun: NotifyLayersUpdated calls mFrameMetrics.IsDefault() after modifying mFrameMetrics

RESOLVED FIXED in mozilla32

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kats, Assigned: kats)

Tracking

unspecified
mozilla32
All
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

This doesn't cause any bugs at the moment, but only because mTransformScale isn't checked as part of FrameMetrics::operator==. I don't know if that's intentional or not but this feels like a footgun to me and should be fixed.
Attachment #8413762 - Flags: review?(botond)
Posted patch Log mTransformScale (obsolete) — Splinter Review
Attachment #8413764 - Flags: review?(botond)
Attachment #8413762 - Flags: review?(botond) → review+
Comment on attachment 8413764 [details] [diff] [review]
Log mTransformScale

Review of attachment 8413764 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/apz/src/AsyncPanZoomController.cpp
@@ +65,5 @@
>  // #define APZC_LOG(...) printf_stderr("APZC: " __VA_ARGS__)
>  #define APZC_LOG_FM(fm, prefix, ...) \
>    APZC_LOG(prefix ":" \
>             " i=(%ld %lld) cb=(%d %d %d %d) rcs=(%.3f %.3f) dp=(%.3f %.3f %.3f %.3f) dpm=(%.3f %.3f %.3f %.3f) um=%d " \
> +           "v=(%.3f %.3f %.3f %.3f) s=(%.3f %.3f) sr=(%.3f %.3f %.3f %.3f) z=(%.3f %.3f %.3f %.3f %.3f) u=(%d %lu)\n", \

I always have to check this code to see what the different components of 'z' are. Perhaps it might make sense to label its components individually?
Attachment #8413764 - Flags: review?(botond) → review+
Updated as requested, carrying r+
Attachment #8413764 - Attachment is obsolete: true
Attachment #8413775 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/ac846d851531
https://hg.mozilla.org/mozilla-central/rev/7f902da7deba
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.