Closed Bug 1002498 Opened 8 years ago Closed 8 years ago

Use mozL10n.once in the Ringtones app

Categories

(Firefox OS Graveyard :: Gaia::Ringtones, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: stas, Assigned: stas)

References

Details

Attachments

(1 file)

The Ringtones app currently uses mozL10n.ready which may behave non-deterministically (bug 993188).  Let's use mozL10n.once (from bug 993189), which is better-suited for initialization tasks.
Attached patch Use mozL10n.onceSplinter Review
https://github.com/mozilla-b2g/gaia/pull/18753

Hi Dominic, are you the right person to review patches for the Ringtones app?  Would you mind taking a look?

See bug 993188 for the description of problems with mozL10n.ready() and https://developer.mozilla.org/en-US/docs/Web/API/L10n.once for the docs on mozL10n.once().

Thanks!
Assignee: nobody → stas
Status: NEW → ASSIGNED
Attachment #8413786 - Flags: review?(dkuo)
Comment on attachment 8413786 [details] [diff] [review]
Use mozL10n.once

Staś,

Thanks for working on this, although we don't officially have owner/peers for the ringtones app, but I am able to review this since I had patches for it and familiar with it(also :djf and :squib), the change is trivial so looks good to me!
Attachment #8413786 - Flags: review?(dkuo) → review+
Thanks, Dominic, and sorry for the weird attachment - it was a paste error; I intended to paste the contents of the diff :)
You need to log in before you can comment on or make changes to this bug.