1002531 - Implement semi transparent scrim for rocketbar

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/18809

Comment 2

[Kevin Grandon :kgrandon]

Dale - this looks good, but my only question is what is a scrim? To be honest, I've never heard of the term in software projects before, so it's throwing me off a bit. Is this the same thing as an overlay/backdrop/shadow?

If I'm not the only person who would question the name and have to stop and think about it for a bit, I'm wondering if we should think about renaming it..

Comment 3

[Dale Harvey (:daleharvey)]

yeh its a backdrop, francis used the name somewhere in the spec I believe and I guess particularly since noone had heard of it before it kept getting used, backdrop probably is more descriptive (I didnt want to use overlay or background as they seemed confusing)

Comment 4

[Dale Harvey (:daleharvey)]

Updated the PR to rename it to backdrop

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8414867 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/18809

Everything works fine, code looks good, has a test. Nice work!

Comment 6

[Kevin Grandon :kgrandon]

Landed without a merge commit cause I know you hate em :)

https://github.com/mozilla-b2g/gaia/commit/a47dc407f41f133e894fc6020909465e24f40b3f

Comment 7

[Dale Harvey (:daleharvey)]

If I convince one person at a time to stop doing merge commits then by 2016 they might be gone complete :) cheers