1002541 - Bump gaiatest version to 0.23 and release to PyPI

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Bob Silverberg [:bsilverberg]]

Now that bug 1000334 has landed, we should release a new gaiatest when bug 1001461 (new marionette client) lands.

Comment 1

[Bob Silverberg [:bsilverberg]]

Attachment: Pull request

Comment 2

[Zac C (:zac)]

Comment on attachment 8413813 [details] [review]
Pull request

r+

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8413813 [details] [review]
Pull request

I would prefer these to be separate commits, so that we can be sure that gaiatest works well on device with the latest Marionette client version before committing to a release. That said, we can just release again if we need to include any fixes.

Note that we can't merge this until Marionette client 0.7.7 is available on PyPI.

Comment 4

[Bob Silverberg [:bsilverberg]]

Marionette client is available on PyPI [1], and I don't believe that bug #1003784 actually blocks this. In fact, I thought Zac specifically wanted to release this before any refactoring changes.

Zac, is this ok to be released to PyPI now?

[1] https://pypi.python.org/pypi/marionette_client/0.7.7

Comment 5

[Bob Silverberg [:bsilverberg]]

I divided this up into 2 commits as Dave requested, which will also trigger another Travis run as the last one failed (because marionette 0.7.7 wasn't available yet).

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Bug 1003784 should block this at least until we prove it doesn't. There's a risk that releasing gaiatest in its current state will regress the suppression of the update notifications for Eideticker, which automatically uses the latest version of gaiatest. I can test the trunk version of gaiatest tomorrow using Eideticker, and if there's no adverse effects then we can release.

I'm now rather baffled how the update notifications are currently suppressed though as the current code doesn't appear to go through the fake update checker path. Ideally we'll expose this so that Eideticker can explicitly call it, and ideally this would be in the upcoming release, but if not having it doesn't cause issues then we can hold it off for a followup release.

I personally think we should land the dependency bump and gaiatest bump separately. There's no reason we can't upgrade Marionette, but there is a potential reason we can't release gaiatest yet. I suppose we could bump the version and hold the release until we're ready, but I prefer to have the version bump immediately precede the release. We've typically handled this scenario in two separate bugs.

Requesting ni? from myself to provide results from running trunk gaiatest with Eideticker.

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

I'm unable to replicate any update notifications after flashing the latest nightly build and connecting my device to a network. It may be that there are no application updates available, and this could explain why we're not seeing these in Eideticker. I'm going to work on bug 1003784 as I would like to include it in this release to be confident that these notifications will not come back.

Comment 8

[Zac C (:zac)]

(In reply to Bob Silverberg [:bsilverberg] from comment #4)
> Marionette client is available on PyPI [1], and I don't believe that bug
> #1003784 actually blocks this. In fact, I thought Zac specifically wanted to
> release this before any refactoring changes.
> 

Yes this was at Dave's request, see above!

Comment 9

[Dave Hunt [:davehunt] [he/him] ⌚BST]

I've landed the Marionette version bump as:
https://github.com/mozilla-b2g/gaia/commit/f953c544bf7a1e87b01b680f84479ba0d9d0bd48

Let's hold off the gaiatest version bump until we see how the new version of Marionette does on CI and we have bug 1003784 resolved.

Comment 10

[Bob Silverberg [:bsilverberg]]

Where do we stand on this, :davehunt? Bug 1003784 has landed. Have we been able to see how the marionette version bump is going on TBPL and elsewhere? I'd really like to get this in today so I can also get my marketplace-tests-gaia PR in too.

Comment 11

[Zac C (:zac)]

0.77 has seemed good so far today.

Comment 12

[Dave Hunt [:davehunt] [he/him] ⌚BST]

If Jenkins is happy with the latest Marionette client (TBPL always uses the version from mozilla-central), then we can go ahead with the gaiatest release. Would you like me to land the remaining commit and then push the release? I cherry-picked the first one from your branch :bsilverberg.

Comment 13

[Bob Silverberg [:bsilverberg]]

Yes please, :davehunt.

Comment 14

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Landed the gaiatest bump in:
https://github.com/mozilla-b2g/gaia/commit/ae3e26b7bbbe4077eb1fc0284f2745eb219033b2

Released gaiatest 0.23:
https://pypi.python.org/pypi/gaiatest/0.23

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0a8d94d7481e