1002550 - Win8: style AppMenu

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

The AppMenu has still a light blueish background which doesn't fit well on Win8 theme. It's better to use -moz-dialog instead.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Win8-AppMenu.patch

Change the background color.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Comparison for ui-r (top without, bottom with patch)

I think the patch is so easy, a screenshot is enough for ui-r.

Comment 3

[Josiah Bruner [:jsbruner]]

Comment on attachment 8413827 [details] [diff] [review]
Win8-AppMenu.patch

Review of attachment 8413827 [details] [diff] [review]:
-----------------------------------------------------------------

Besides the nits, this looks great. r+.

(I was noting on IRC that we should eventually remove all these less than Win 8/ Win8 media queries and just set a bunch of variables instead)

::: mail/themes/windows/mail/primaryToolbar-aero.css
@@ +1019,5 @@
>  }
>  
> +@media (-moz-windows-default-theme) and (-moz-os-version: windows-vista),
> +       (-moz-windows-default-theme) and (-moz-os-version: windows-win7) {
> +  /* < Win8 */

Didn't we go over this. ;) No need for the comment.

@@ +1086,5 @@
> +  }
> +}
> +
> +@media (-moz-os-version: windows-win8) {
> +  /* >= Win8 */

Ditto.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: Win8-AppMenu.patch

Now with variables. Makes it simpler.

Comment 5

[Josiah Bruner [:jsbruner]]

Comment on attachment 8413899 [details] [diff] [review]
Win8-AppMenu.patch

Review of attachment 8413899 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, and much simpler!

(I didn't test though, I assume you did that)

r+

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/ff44362c86bc

Comment 7

[Richard Marti (:Paenglab)]

Comment on attachment 8413899 [details] [diff] [review]
Win8-AppMenu.patch

[Approval Request Comment]
User impact if declined: No, but not a well integrated AppMenu color to Win8
Testing completed (on c-c, etc.): landed in c-c
Risk to taking this patch (and alternatives if risky): Low, it's only CSS

It would be good if this could land in the next ESR version.

Comment 8

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-aurora/rev/bdc1746d4450