Closed Bug 1002606 (sccache-mac) Opened 10 years ago Closed 10 years ago

Enable sccache for mac try buildss

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86_64
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla32

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(2 files, 1 obsolete file)

setup.sh for tooltool
88 bytes, text/plain
rail
: review+
Details
Enable sccache for mac try builds
4.99 KB, patch
glandium
: review+
Details | Diff | Splinter Review 
      No description provided.
Attached file setup.sh for tooltool — 
Assignee: nobody → mh+mozilla

        Attachment #8413866 -
        Flags: checkin?(rail)

    
  
Depends on: 1002614

    
  

        Attachment #8413866 -
        Flags: review?(rail)

    
    

    
  


  

        Attachment #8413900 -
        Flags: review?(mshal)

    
  
Alias: ccache-mac → sccache-mac

    
  

        Attachment #8413866 -
        Attachment mime type: application/x-shellscript → text/plain

        Attachment #8413866 -
        Flags: review?(rail) → review+

    
    

    
  
Comment on attachment 8413866 [details]
setup.sh for tooltool


size: 88
sha512: 0d2ae9bcd7cea34ec0b768270725e98410dbb3bc150c7381e0dcf3eb5dbb3e69ac76dbb0f46b056151d6a6fa8681cab06da68173ae8598f3397b8f7628e67381

        Attachment #8413866 -
        Flags: checkin?(rail) → checkin+

    
    

    
  
Comment on attachment 8413900 [details] [diff] [review]
Enable sccache for mac try builds

>diff --git a/b2g/config/mozconfigs/macosx64_gecko/nightly b/b2g/config/mozconfigs/macosx64_gecko/nightly
>--- a/b2g/config/mozconfigs/macosx64_gecko/nightly
>+++ b/b2g/config/mozconfigs/macosx64_gecko/nightly
>@@ -1,9 +1,13 @@
> . "$topsrcdir/b2g/config/mozconfigs/common"
>+
>+# Use sccache
>+no_sccache=

Is there a reason we want this on for nightly but not for debug builds? For bug 996307 we turned it on for both for linux64_gecko builds. (linux32_gecko oddly doesn't have it on in debug builds, but that was added later in bug 916111. We'll probably need to fix that so they're at least consistent)

        Attachment #8413900 -
        Flags: review?(mshal) → review+

    
    

    
  
Oh this is interesting. I only did it on nightly because on try, doing -b do -p macosx64_gecko doesn't do a debug build.

    
    

    
  
(In reply to Michael Shal [:mshal] from comment #4)
> (linux32_gecko oddly doesn't have it on in debug builds, but that was added later in bug
> 916111. We'll probably need to fix that so they're at least consistent)

File a bug ;)

    
  

        Attachment #8413900 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 8414056 [details] [diff] [review]
Enable sccache for mac try builds

Carrying over r+

        Attachment #8414056 -
        Flags: review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/54c16794c7e5
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32

    
  
Blocks: 1008015

    
  
Product: Core → Firefox Build System

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: