Closed Bug 1002619 Opened 7 years ago Closed 7 years ago

Syntax error in Marionette's setup.py

Categories

(Testing :: Marionette, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla32

People

(Reporter: wlach, Assigned: wlach)

Details

(Keywords: pi-marionette-client)

Attachments

(1 file)

Simple logic error:

wlach@eideticker:~/src/mozilla-central-hg/testing/marionette/client$ pyflakes setup.py
setup.py:30: undefined name 'directory'

Note that you can usually avoid this class of error by setting pyflakes up to automatically syntax check in your editor, see the comments here: http://wrla.ch/blog/2012/10/catching-problems-early-with-python/
Attached patch Simple fixSplinter Review
Assignee: nobody → wlachance
Attachment #8413870 - Flags: review?(ato)
Attachment #8413870 - Flags: review?(ato) → review+
This can go in anytime. DONTBUILD is an option here.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2c9dd078b08c
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.