1002750 - Characters "non-English" not show fine in menu "Help-About"

Status: NEW

(Firefox :: General, defect)

Description

[João Mac-Cormick]

Attachment: firefox preferences distribution with problem.png

User Agent: Mozilla/5.0 (Windows NT 5.2; rv:28.0) Gecko/20100101 Firefox/28.0 (Beta/Release)
Build ID: 20140314220517

Steps to reproduce:

1) URL-> about:config
2) Set preferences ("distribution.id";"ã & ó"), ("distribution.version";"ã & ó") and ("distribution.about";"ã & ó") with characters "non-English" 
3) Access the Help menu, option "About"


Actual results:

Preferences "distribution.id" and "distribution.version" are not displayed correctly. :(
Preference "distribution.about" are displayed correctly. :)


Expected results:

The preferences "distribution.id" and "distribution.version" should display non-English characters correctly. Preference "distribution.about" are displayed correctly. :)

Comment 1

[YF (Yang)]

Like bug 895473, them also need 'Services.prefs.getComplexValue'.
ref: http://hg.mozilla.org/mozilla-central/file/cfde3603b020/browser/base/content/aboutDialog.js#l10

Comment 2

[Robert Strong (they/them - no direct email)]

Bug 900925 is about an error message being displayed in the console and has nothing to do with this bug so unblocking.

Comment 3

[YF (Yang)]

Attachment: patch v1

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 8414157 [details] [diff] [review]
patch v1

Thanks for patching. r- for two reasons:

- We should not retrieve distribution.id twice.

- I also think it is unnecessary to move the retrieval of distribution.version into the inner try/catch block, unless there is evidence that this is problematic in practice.

Comment 5

[YF (Yang)]

Attachment: patch v2

Thanks you to point out the issue! in this way?

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 8415911 [details] [diff] [review]
patch v2

Thanks for the updated patch, but now it's not clear to me why you're moving the distroVersion/distroIdField code outside of the "if (distroId)" block. This patch should just be a simple switch from getCharPref to getComplexValue with no other moving things around, as I understand it.

Comment 7

[João Mac-Cormick]

I came here to report that the problem continues to release 75.0.

Comment 8

[João Mac-Cormick]

Attachment: firefox preferences distribution with problem in release 75.png

Comment 9

[João Mac-Cormick]

workaround

1. create "[app path]/defaults/pref/autoconfig.js" file
   // dummy
   pref("general.config.obscure_value", 0);
   pref("general.config.filename", "mozilla.cfg");

2. create "[app path]/mozilla.cfg"

2.1) encode ASCII file
// dummy
lockPref( "distribution.about", unescape( encodeURIComponent( "Por João Mac-Cormick" ) ) );
lockPref( "distribution.id", "pacote da casa do João Mac-Cormick" );
lockPref( "distribution.version", "versão 2020.4" );

OR

2.2) encode UTF-8 file
// dummy
lockPref( "distribution.about", "Por João Mac-Cormick" );
lockPref( "distribution.id", decodeURIComponent( escape( "pacote da casa do João Mac-Cormick" ) ) );
lockPref( "distribution.version", decodeURIComponent( escape( "versão 2020.4" ) ) );