Closed Bug 1002777 Opened 10 years ago Closed 10 years ago

eBay search URLs are changing

Categories

(Firefox :: Search, defect)

x86_64
Windows 8
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 32

People

(Reporter: mconnor, Assigned: mconnor)

References

Details

Attachments

(1 file)

Update destination URLs for search box 

Currently http://rover.ebay.com/rover/1/{tracked country code}/4?mpre=http://shop.ebay.{tld}/?_nkw={query}
Updated to http://rover.ebay.com/rover/1/{tracked country code}/4?mfe=search&mpre=http://www.ebay.{tld}/sch/i.html?_nkw={query}

Update Autocomplete URL for search box 
Currently http://anywhere.ebay.com/services/suggest/?s={site id}&q={query}
Updated to http://autosug.ebay.com/autosug?kwd={query}&sId={site id}&fmt=osr

patch incoming.
Attached patch ebayUpdateUSSplinter Review
Attachment #8414066 - Flags: review?(adw)
Blocks: 998072
Comment on attachment 8414066 [details] [diff] [review]
ebayUpdateUS

Review of attachment 8414066 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/searchplugins/eBay.xml
@@ +7,5 @@
>  <Description>eBay - Online auctions</Description>
>  <InputEncoding>ISO-8859-1</InputEncoding>
>  <Image width="16" height="16">data:image/x-icon;base64,AAABAAIAEBAAAAAAAAB6AQAAJgAAACAgAAAAAAAAQgMAAKABAACJUE5HDQoaCgAAAA1JSERSAAAAEAAAABAIBgAAAB/z/2EAAAFBSURBVDjLtZPdK0MBGIf3J5Babhx3rinFBWuipaUskX9DYvkopqgV90q5UJpyp0OKrUWM2VrRsS9D0zZKHGaOnW1nj4vtypVtPPe/533r9746QAAOAJXfo5Yzgg44pHrcugon/6Sgo0b+XuAOZ2iZiVQmyPoDpIwmUkYTzqM7GsdDdC7F6Lbf8pzOkfWOouzqeZem2b+2AqAV8zjD8yVBqqcf2b7C66yNiMGMfixIQSvi8Mp0LEbR5ADq1QSKWM+Gx0RC9nOZ2GLzwlIWdPWiuNzk4w/EpThNkyEAXKEP2ud8KGId2sspilhPMrmNwzfCuqePr/xbSfC5I/I0MMSj2YJ3z49gDdO2cEOrLUowJpE9G0QRG1ClKbR0EIdvmOPYcnUtnN+vsnZiQC1k/qnGagQ1n3LNzySUJZVskitnmr8BlQG7T2hvgxsAAAAASUVORK5CYIKJUE5HDQoaCgAAAA1JSERSAAAAIAAAACAIBgAAAHN6evQAAAMJSURBVFjD7ZddSFNhGMeHXXQTZFFCWfR1pRhUECQlBdWVToo+6KYu1KigtDASG5qUfZgFZvahEDosECPDktKZS1FL+1DRnEvdUptjug91X2dnZzv/3vO6OZbWnR4v9sADL+fs7P97/s/znu2VAJD4UkpSSdKG+QubTyPBr+sXz8XCR64fIAHihVTis0SsUAoAVhEBrBKIHCGAEMB/ARi3F5LkbpS2WMRzYEEBXC2tsD6T03R9agsCGLNyqPw6CXmrBT06JvhbPHZwmkdwtR0B138PPKOHgzXD5jLAy3tmibo4K9weZwDAazJj/FQKRnfugfHMeRiTz0K3Ixam1HQKcPC+Fisu9NK1P08Uj4DleHgMdXC+WQ7nu3UEOhFMfTQcVUvQ1H4IN2sj8H2k7K+2TqCc3GseyA8AmDOzMBq7D9bS8sAr6nEJdNt3UbHVF1XQGtmZew8bTPT6tWoD3KpsUvlR8NxUoEICMvl6KQo+xqCwcRs4T8Ax5c8bFExjbAgAjO7aS8VsLypgq3g5nWStjztAhWRVhqAqeB6IuKTClkw1eNYEbrCQQBwD8yGGOsAooogLYejQPKBi7UPF9DkH+ezd+o141ZkUPAOC+L9SAMivNc7q46YMNSLTe4n1kaQF4XD3ZIDTPgU3XEYciKcAHrsGJS1xKFBGgyVzouiT4VbdGhjt/cEA5isyKsaz7jl3we7bg7Rqf6j0LoSldON4wWcqJDgQNGTN++l13vELA+MK6kKd6iryFOvxtidt9i5gO7owdjKJQliflNAU1pas6xQgnAzg1ux+lJEdILixNr0Pq9JUUA8NwVG9DM73G0jlcnh+V4BpjIWzJmIGQIjnXw5TiDuKSEwxurm3ITc8DNO51BnrLbIcsrW0dNA6RxgUKU1UdGVqLy5X6qGzTLvlnewiBZyGs3Yz6X8UeaYI3olvZDhzwLumZ+eHvooCCC0Q5VUsb4unwycM4YIDqA01tPqmgbzQr2EIYPECiPm33LYoDiZSsY9moh9O/Znoa4d9HkXtPg2pX/cPKCoRQ+ocZa4AAAAASUVORK5CYII=</Image>
> +<Url type="application/x-suggestions+json" method="GET" template="http://autosug.ebay.com/autosug">
> +  <Param name="sId" value="0" />

I'm sure you know what you're doing, but just want to point out 0 is hardcoded here but comment 0 says {site id}, in case this is a typo or something.
Attachment #8414066 - Flags: review?(adw) → review+
It's hardcoded for en-US, it's different for other locales. They'll have their own plugins, because we can't really do MozParam-like substitutions in URLs.
Depends on: 1003415
https://hg.mozilla.org/mozilla-central/rev/070ba75ffd60
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0

The links below appear in Firefox 32 beta 4 (20140804164216), Newtowk section of the Developer Toolbox:

http://rover.ebay.com/rover/1/711-47294-18009-3/4?mfe=search&mpre=http://www.ebay.com/sch/i.html?_nkw=iphon
http://autosug.ebay.com/autosug?sId=0&kwd=iphon&fmt=osr

Marking as verified.
Status: RESOLVED → VERIFIED
Keywords: verifyme
QA Contact: petruta.rasa
You need to log in before you can comment on or make changes to this bug.