Closed Bug 1002795 Opened 6 years ago Closed 6 years ago

Remove profileInlineFrames option

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: djvj, Assigned: djvj)

References

Details

Attachments

(1 file)

Inline frame profiling was turned off a while back (by me), but with the option to turn it back on hidden behind a JitOptions field.

This is causing problems, namely with bug 970252.  No-inline-profiling has been in the tree for a while now with no major complaints.  It should be OK to remove the option now, permanently disable inline profiling, and enable us to move forward with fixing existing bugs.
Comment on attachment 8414078 [details] [diff] [review]
remove-profile-inline-frames-option.patch

Giving this review to you since you reviewed the original patch that disabled inline frame profiling.  We're just removing the configurable option here.
Attachment #8414078 - Flags: review?(hv1989)
Comment on attachment 8414078 [details] [diff] [review]
remove-profile-inline-frames-option.patch

Review of attachment 8414078 [details] [diff] [review]:
-----------------------------------------------------------------

Interesting nobody complained or had problems understanding where some time was spend.
But it makes sense to remove this options if it causes extra dev time for unused option.
Thanks

::: js/src/jit/BaselineBailouts.cpp
@@ +1419,5 @@
>      }
>      IonSpew(IonSpew_BaselineBailouts, "  Done restoring frames");
>  
>      // If there were multiple inline frames unpacked, and inline frame profiling
>      // is off, then the current top SPS frame is for the outermost caller, and

Please adjust comment to not include "inline frame profiling is off"
Attachment #8414078 - Flags: review?(hv1989) → review+
https://hg.mozilla.org/mozilla-central/rev/c5edc4d488cb
Assignee: nobody → kvijayan
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.