Closed
Bug 1002797
Opened 10 years ago
Closed 10 years ago
[jsdbg2] Cancel off thread Ion compilation when doing debug mode OSR
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: shu, Assigned: shu)
Details
Attachments
(1 file)
1.86 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
Else we trip asserts when calling setBaselineScript.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8414088 -
Flags: review?(jdemooij)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → shu
Status: NEW → ASSIGNED
Comment 2•10 years ago
|
||
Comment on attachment 8414088 [details] [diff] [review] Cancel off-thread Ion compilation when doing debug mode OSR Review of attachment 8414088 [details] [diff] [review]: ----------------------------------------------------------------- Makes sense, though I'd slightly prefer a StopAllOffThreadCompilations(comp); in RecompileOnStackBaselineScriptsForDebugMode, to make it easier to reason about: "there's no off-thread Ion compilation running at this point". Also, ~AutoDebugModeInvalidation will run shortly after we recompile baseline scripts and it's going to cancel them anyway.
Attachment #8414088 -
Flags: review?(jdemooij) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0112ac69a293
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0112ac69a293
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•