Closed
Bug 1002849
Opened 11 years ago
Closed 11 years ago
Extra Padding in Footer
Categories
(support.mozilla.org :: General, defect, P4)
support.mozilla.org
General
Tracking
(Not tracked)
RESOLVED
FIXED
2014Q2
People
(Reporter: anushbmx, Assigned: anushbmx)
Details
(Whiteboard: u=user c=general p=0 s=2014.9 [good first bug] [mentor=mythmon])
Attachments
(1 file)
|
470.07 KB,
image/png
|
Details |
Sumo with 10px padding in footer
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140427195542
Steps to reproduce:
There is 110px of padding applied to the bottom side of footer, which seems too hight comparing with other website in mozilla.
|
||
Comment 1•11 years ago
|
||
Anush told me in IRC that he wants to work on this. I think it is a simple style change, so it's a good bug to start with.
Assignee: nobody → anush
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Whiteboard: [good first bug] [mentor=mythmon]
|
Assignee | |
Comment 2•11 years ago
|
||
padding bottom 10px looks file if its fine for the community I can initiate the PR
|
||
Comment 3•11 years ago
|
||
Pull request:
https://github.com/mozilla/kitsune/pull/1944
|
|
||
Comment 4•11 years ago
|
||
Landed on master:
https://github.com/mozilla/kitsune/commit/68305ae00cf482e3147c0cbb0d3a244a7203d654
Thanks Anush!
|
|
||
Comment 5•11 years ago
|
||
sprint metadata.
Priority: -- → P4
Whiteboard: [good first bug] [mentor=mythmon] → u=user c=general p=0 s=2014.9 [good first bug] [mentor=mythmon]
Target Milestone: --- → 2014Q2
|
|
||
Comment 6•11 years ago
|
||
Deployed to prod now.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•