1002857 - stop disabling GL layers for 10.6.2 and below

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Andreas Gal :gal]

This might break on some very old macs that didn't update to 10.6.3, but in that case you have much bigger problems anyway (security) plus its 3 versions behind current macosx. 10.6.3 is a free update. We should relnote this.

Comment 1

[Andreas Gal :gal]

Attachment: patch

Comment 2

[Andreas Gal :gal]

Attachment: patch

Comment 3

[Benoit Girard (:BenWa)]

We've supported 10.6.0 - 10.6.2 long enough. I think moving our official min requirement to 10.6.2 is a good move to focus resources on recent OSX.

But I feel like this needs broad approval so I'm going to bring this up in the next graphics meeting.

Comment 4

[Benoit Girard (:BenWa)]

Note that we uplifted a patch to beta in FF18 (start of 2013) to restore this blacklist because of user report so the impact is likely to be non zero. I still think we should consider doing this however.

See bug 829710.

Comment 5

[Kelsey Gilbert [:jgilbert]]

(In reply to Benoit Girard (:BenWa) from comment #3)
> We've supported 10.6.0 - 10.6.2 long enough. I think moving our official min
> requirement to 10.6.2 is a good move to focus resources on recent OSX.
> 
> But I feel like this needs broad approval so I'm going to bring this up in
> the next graphics meeting.

For clarity, did you mean moving to 10.6.3 as minimum?

Comment 6

[Benoit Girard (:BenWa)]

Yes I did.

We discussed this on the graphics meeting. Here's the summary:
- According to our crash data stats 10.6.0 - 10.6.2 has a trivial user base and consumes a small but disproportionate resources that would be better spent else where especially since 10.6.3 is a free patch.

We decided that we should instead take an independent decision to drop support for 10.6.2 and below which I will file as a dependent bug and we can discuss with the relevant parties. Once that bug is resolved this patch is a trivial r+ since it becomes dead code.

Comment 7

[Benoit Girard (:BenWa)]

Comment on attachment 8414143 [details] [diff] [review]
patch

Let's wait on bug 1003270, once it's fixed this r+ is trivial.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Like in bug 1003270, please resubmit to the release notes when it landed.

Comment 9

[Benoit Girard (:BenWa)]

I'm not working on this. Given how much effort it is to blacklist a minor OS X version it will probably be easier to just wait until we drop 10.6 altogether.

Comment 10

[Stefan [:stefanh]]

We've now dropped support for < 10.9, see bug 1255589.

Comment 11

[Benoit Girard (:BenWa)]

Alright now that we're not waiting on bug 1003270 we should get rid of this check.

Comment 12

[Benoit Girard (:BenWa)]

Attachment: MozReview Request: Bug 1002857 - stop disabling GL layers for 10.6.2 and below. r=mstange

Review commit: https://reviewboard.mozilla.org/r/53720/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53720/

Comment 13

[Markus Stange [:mstange]]

Comment on attachment 8754092 [details]
MozReview Request: Bug 1002857 - stop disabling GL layers for 10.6.2 and below. r=mstange

https://reviewboard.mozilla.org/r/53720/#review50720

Might as well remove the gfxPlatformMac::AccelerateLayersByDefault() override completely.

Comment 14

[Benoit Girard (:BenWa)]

I looked but it wasn't trivial. This does push it in the right direction however:
http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxPlatform.cpp#2166

Best to leave it as a follow-up.

Comment 15

[Markus Stange [:mstange]]

Is MOZ_GL_PROVIDER not always defined for Mac? Mac uses GLContextProviderCGL, and I thought that define picked that.

Comment 16

[Benoit Girard (:BenWa)]

Ohh you meant specifically the mac override. I assumed you meant everything because that's what I looked at doing.

Comment 17

[Benoit Girard (:BenWa)]

Comment on attachment 8754092 [details]
MozReview Request: Bug 1002857 - stop disabling GL layers for 10.6.2 and below. r=mstange

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53720/diff/1-2/

Comment 18

[Benoit Girard (:BenWa)]

Since my auto-land request didn't go through I amended the changes in Comment 15.

Comment 19

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca3135fa04fc

Comment 20

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ca3135fa04fc