Closed Bug 1002887 Opened 6 years ago Closed 6 years ago
.jsm should not be preprocessed
No description provided.
Attachment #8414167 - Flags: review?(mshal)
Comment on attachment 8414167 [details] [diff] [review] Patch (v1) How did you end up finding this particular file? Should we have a way to check if a file is preprocessed that doesn't have any preprocessor tokens? Maybe we could fail the build in that case so they don't go into the wrong bin.
Attachment #8414167 - Flags: review?(mshal) → review+
We show warnings such as: /Users/ehsan/moz/src/toolkit/components/telemetry/UITelemetry.jsm: WARNING: no preprocessor directives found during the build. And I finally got sick of seeing them every since time. I'd fix them all if I didn't have to file tens of bugs for each individual one. ;-) https://hg.mozilla.org/integration/mozilla-inbound/rev/6485e93761a6
> I'd fix them all if I didn't have to file tens of bugs for each individual one. ;-) You don't have to file a bug for each individual one.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.