Closed
Bug 1003003
Opened 10 years ago
Closed 10 years ago
B2G camera code doesn't hold monitor when calling Notify
Categories
(Core :: WebRTC: Audio/Video, defect)
Tracking
()
People
(Reporter: jesup, Assigned: jesup)
References
Details
(Keywords: regression)
Attachments
(1 file, 2 obsolete files)
1.72 KB,
patch
|
mikeh
:
review+
|
Details | Diff | Splinter Review |
This is in AllocImpl(), which calls mCallbackMonitor.Notify() without holding the monitor. I'm not sure this ever worked right, except by luck. A debug run should always have caught it. Note that for a long while I couldn't build debug B2G locally due to a GCC crash. Notify() requires holding the monitor.
Assignee | ||
Comment 1•10 years ago
|
||
WIP patch - I also had to disable camera rotation code to get debug builds to run; though really that's a separate bug and will be filed. With this patch, gum Video works on a Flame
Assignee | ||
Comment 2•10 years ago
|
||
now without patch to disable rotation check (bug 1003006)
Assignee | ||
Updated•10 years ago
|
Attachment #8414275 -
Attachment is obsolete: true
Assignee | ||
Comment 3•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8414280 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Attachment #8414281 -
Flags: review?(mhabicher)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → rjesup
Comment 4•10 years ago
|
||
Comment on attachment 8414281 [details] [diff] [review] Hold B2G camera callback monitor if we're going to call Notify() on it Review of attachment 8414281 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me.
Attachment #8414281 -
Flags: review?(mhabicher) → review+
Assignee | ||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/67184a49505d
Target Milestone: --- → mozilla32
Updated•10 years ago
|
Keywords: regression
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/67184a49505d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 7•10 years ago
|
||
I think we know this is a regression, but what's the impact of this on 1.4 if we don't fix this?
Comment 8•10 years ago
|
||
(In reply to Jason Smith [:jsmith] from comment #7) > I think we know this is a regression, but what's the impact of this on 1.4 > if we don't fix this? Clarified in IRC - makes sense to block on this now.
blocking-b2g: 1.4? → 1.4+
Assignee | ||
Updated•10 years ago
|
Whiteboard: [webrtc-uplift]
You need to log in
before you can comment on or make changes to this bug.
Description
•