1003020 - [bluez][PTS][Certification]Refine battery level calculation for indicator test case TC_AG_PSI_BV_03_I

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Refine battery level calculation for indicator test case TC_AG_PSI_BV_03_I

Comment 1

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 1003020 - [bluez][PTS][Certification]Refine battery level calculation for indicator test case TC_AG_PSI_BV_03_I (1.3)

Comment 2

[Ben Tian (inactive)]

Attachment: Patch 1: (v1.3, bluez) Update to the latest battery level when HFP manager inits

iaohong, can you try if the patch corrects battery level for test case TC_AG_PSI_BV_03_I? The patch retrieves the latest battery level when HFP manager initializes, instead of keeping default level as 5.

Comment 3

[yang.xiaohong]

Attachment: TC_AG_PSI_BV_03_I.7z

Still failed after patch1. logs see attachment.

Comment 4

[yang.xiaohong]

Dose this patch compiled in libxul.so? 
adb push E:\Logs\FFOS\BQB\libxul.so /system/b2g. Is it correct?

Comment 5

[Ben Tian (inactive)]

(In reply to yang.xiaohong from comment #3)
> Created attachment 8417865 [details]
> TC_AG_PSI_BV_03_I.7z
> 
> Still failed after patch1. logs see attachment.
The failure is similar to bug 981458. Did your build have the fix?
https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/b021cf83cb5d

Comment 6

[yang.xiaohong]

Yes, the build contains this fix already. ---> SendCommand("+CIEV: ", CINDType::BATTCHG);

Comment 7

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

(In reply to yang.xiaohong from comment #6)
> Yes, the build contains this fix already. ---> SendCommand("+CIEV: ",
> CINDType::BATTCHG);

But based on your log, Attachment 8417865 [details], 
145	Master	46	..+CIEV:1..		Battery charge indicator's status report		
frame 145, seems to miss that patch, I did not see any empty space after '+CIEV:'.
https://bugzilla.mozilla.org/show_bug.cgi?id=981458#c20 shows this test case had been passed. Can you confirm again? Maybe you can add log such as 'BT_LOGR("battery update indicator");'?

Comment 8

[yang.xiaohong]

hi Shawn,
We retried this patch, it works. I think the lab QA pushed .so file incorrectly last time. 
Thanks a lot!

Comment 9

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

(In reply to yang.xiaohong from comment #8)
> hi Shawn,
> We retried this patch, it works. I think the lab QA pushed .so file
> incorrectly last time. 
> Thanks a lot!
Let apply it on master first.

Comment 10

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

(In reply to Shawn Huang [:shuang] [:shawnjohnjr] from comment #9)
> (In reply to yang.xiaohong from comment #8)
> > hi Shawn,
> > We retried this patch, it works. I think the lab QA pushed .so file
> > incorrectly last time. 
> > Thanks a lot!
> Let apply it on master first.

(unexpected to submit comments)
Let's apply it on master first. It looks like Sora can pass this test without patch.

Comment 11

[Ben Tian (inactive)]

Attachment: Patch 1: (m-c) Update to the latest battery level when HFP manager inits

Comment 12

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Comment on attachment 8420883 [details] [diff] [review]
Patch 1: (m-c) Update to the latest battery level when HFP manager inits

Review of attachment 8420883 [details] [diff] [review]:
-----------------------------------------------------------------

Based on Comment 8. It shall be good to go!

Comment 13

[Ben Tian (inactive)]

try: https://tbpl.mozilla.org/?tree=Try&rev=01dd11c6c1e0

Comment 14

[Ben Tian (inactive)]

https://hg.mozilla.org/integration/b2g-inbound/rev/07596b210635

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/07596b210635