Closed Bug 1003038 Opened 11 years ago Closed 11 years ago

English strings on localized download pages

Categories

(www.mozilla.org :: L10N, defect)

Product:
www.mozilla.org
Component:
L10N
Version:
Production
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: sprussak, Assigned: agibson)

Details

Steps to reproduce: Go to https://www.mozilla.org/pl/firefox/new/ Look at the list of links below the localized "Different by design" header. "Learn about Firefox OS" and "Get Firefox on your Android device" are displayed in English. I checked it on some other locales and this bug seems to affect all the ones I checked. The strings look like they are hardcoded: they are not displayed as untranslated on the web dashboard and if they are anywhere in the SVN files, I cannot find them.
Looks like it landed in the big merge of branches last night, I am going to add them right now to the lang files
So one I imported from home.lang which had the same string, there is one that is to translate "Get Firefox on your Android device", it's in your repo. In the meantime, we are preparing a temporary patch that will allow us to activate the link on the page only if it is translated. Thanks for reporting Sara, we had not noticed yet, it was very useful :) Let's use this bug for the template patch.
Assignee: nobody → agibson
oh, actually the string we have localized is "Learn more about Firefox OS" while the string in the template is "Learn about Firefox OS" :/ So that's 2 strings
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/1da9b1f91ae1dce3d1a554c0d6cd92081c231ef5 [bug 1003038] English strings on localized download pages https://github.com/mozilla/bedrock/commit/df8516e24c84753b0b6773092f5d50deb73ebf33 Merge pull request #1937 from alexgibson/bug-1003038-english-strings-on-localized-download-pages [bug 1003038] English strings on localized download pages
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Verified This with tag has all the links http://www.mozilla.org/pl/firefox/new/ This one incomplete is not showing English strings http://www.mozilla.org/vi/firefox/new/
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.