1003041 - Merge PRenderFrame() and InitRenderFrame() ?

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Both PRenderFrame() and InitRenderFrame() are sync messages from child to parent
and based on profiles we end up waiting for the reply from the parent.
So,if we could do just one wait, not two.
It is hard to estimate how much that would help, but we end up waiting for
>10ms waiting for the replies.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Ah, this is a recent regression, from bug 919878

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I guess it would be fine to merge them as long as we keep the success parameter. I think I split them up because it seemed weird to have the constructor behave that way. But if it matters for performance, it seems fine.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

It seems to be rather important from performance point of view.
Child process is just waiting for quite some time doing nothing.

(But need to think about initialization steps a bit more. I think we should aim
for no sync child-parent messages during normal <iframe mozbrowser> initialization.)

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v1

https://tbpl.mozilla.org/?tree=Try&rev=06edabc0d44a

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Commit message: "Bug 1003041 - Merge PRenderFrame() and InitRenderFrame() to avoid extra sync child->parent messaging, r=billm"

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/edd0cd3d8750

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/edd0cd3d8750