Closed
Bug 1003089
Opened 10 years ago
Closed 10 years ago
Skip test_receive_call if plivo key is missing
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: zcampbell, Assigned: zcampbell)
Details
Attachments
(1 file)
This test is failing on the Tpe server because they do not have Plivo set up. Skip the test if the key is not set in the testvars file, exactly the same as we have configured for email tests.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → zcampbell
|
|
Assignee | |
Comment 1•10 years ago
|
||
Askeing and Eric, merge this when you r+ so you don't get this test failing on your CI!
Attachment #8414454 -
Flags: review?(fyen)
Attachment #8414454 -
Flags: review?(echang)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8414454 [details] [review] github pr Or njpark, if you get to this first it will be helpful for tpe team :)
Attachment #8414454 -
Flags: review?(npark)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8414454 [details] [review] github pr ran fine locally. when i masked the variable, it skips normally. One should assume that pilvo var always contains all relevant info as a set, (id, token, number) but if that is the case, looks good to me.
Attachment #8414454 -
Flags: review?(npark) → review+
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8414454 [details] [review] github pr works fine on my local machine, r+ thanks :)
Attachment #8414454 -
Flags: review?(fyen) → review+
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8414454 -
Flags: review?(echang)
|
|
Assignee | |
Comment 5•10 years ago
|
||
Merged: https://github.com/mozilla-b2g/gaia/commit/489ce25ab41823a4c187ee1e39c50839d8e3eab0
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•