Closed
Bug 1003093
Opened 10 years ago
Closed 10 years ago
After firing the pointercancel event, a user agent MUST also fire a pointer event named pointerout followed by firing a pointer event named pointerleave
Categories
(Firefox for Metro Graveyard :: Browser, defect)
Firefox for Metro Graveyard
Browser
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 32
People
(Reporter: alessarik, Assigned: alessarik)
Details
Attachments
(1 file)
According specification of Pointer Events PointerOut event should be after PointerCancel event
Assignee | ||
Comment 1•10 years ago
|
||
+ changes: sequence of PointerCancel and pointerOut
Attachment #8414435 -
Flags: review?(mbrubeck)
Attachment #8414435 -
Flags: review?(jmathies)
Attachment #8414435 -
Flags: review?(bugs)
Attachment #8414435 -
Flags: feedback?(romaxa)
Attachment #8414435 -
Flags: feedback?(nicklebedev37)
Assignee | ||
Comment 2•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=7f09e25f58f3
Comment 3•10 years ago
|
||
Comment on attachment 8414435 [details] [diff] [review] out_after_cancel_ver1.diff Review of attachment 8414435 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. A test would be useful for this too.
Attachment #8414435 -
Flags: review?(mbrubeck) → feedback+
Comment 4•10 years ago
|
||
Comment on attachment 8414435 [details] [diff] [review] out_after_cancel_ver1.diff Hmm I did not get it. we have this bug already fixed here: bug 974177 with test attached. Any explanation why this has to be moved into PostHandle instead of Pre?
Assignee | ||
Comment 5•10 years ago
|
||
(In reply to Oleg Romashin (MS) from comment #4) > Any explanation why this has to be moved into PostHandle instead of Pre? Please, see specification: AFTER firing the pointercancel event, a user agent MUST also fire a pointer event named pointerout followed by firing a pointer event named pointerleave. > we have this bug already fixed here: bug 974177 with test attached. Unfortunately, attached test_bug970964 check only existing pointerOut for pointerCancel. But test doesn't check sequence of this events.
Assignee | ||
Comment 6•10 years ago
|
||
(In reply to Matt Brubeck (:mbrubeck) from comment #3) > Looks good to me. A test would be useful for this too. I will attach test to bug 1000870, when according test will be reviewed by w3c.
Comment 7•10 years ago
|
||
Comment on attachment 8414435 [details] [diff] [review] out_after_cancel_ver1.diff Generally looks ok to me but I'm not a peer for this area of the code base. smaug or enn are probably the right reviewers for this.
Attachment #8414435 -
Flags: review?(jmathies)
Updated•10 years ago
|
Attachment #8414435 -
Flags: review?(bugs) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 9•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5bfa3b6dae2a
Status: UNCONFIRMED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 32
Updated•10 years ago
|
Attachment #8414435 -
Flags: feedback?(romaxa) → feedback+
Updated•10 years ago
|
Attachment #8414435 -
Flags: feedback?(nicklebedev37)
You need to log in
before you can comment on or make changes to this bug.
Description
•